-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
derive macro warning: unexpected cfg
condition name: wasm_bindgen_unstable_test_coverage
#4283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For anyone else coming across this, you can statically declare the cfg as expected by adding the following to your [lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] } |
Fixed by #4284. |
nice, that's a better fix than just ignoring the lint |
since this can break CI by emitting a warning to potentially a lot of people, it would be nice to have a patch release |
I plan to make one today or at the latest tomorrow. |
When using nightly version of the compiler, building for wasm32 target emits a bunch of warnings rooted in the `wasm_bindgen` macro: ``` warning: unexpected `cfg` condition name: `wasm_bindgen_unstable_test_coverage` ``` This commit prevents this noise by following the suggestion from the related `wasm_bindgen` issue: [rustwasm/wasm-bindgen#4283].
When using nightly version of the compiler, building for wasm32 target emits a bunch of warnings rooted in the `wasm_bindgen` macro: ``` warning: unexpected `cfg` condition name: `wasm_bindgen_unstable_test_coverage` ``` This commit prevents this noise by following the suggestion from the related `wasm_bindgen` issue: [rustwasm/wasm-bindgen#4283].
This comment was marked as resolved.
This comment was marked as resolved.
Recently, CI jobs started failing on the `rust:lint` step. One suitable workaround was to ignore the questionable lints via Cargo.toml: ``` [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] } ``` However we can just bump the dep and skip ignoring the lints. See related discussion in [0]. [0] rustwasm/wasm-bindgen#4283
Recently, CI jobs started failing on the `rust:lint` step. One suitable workaround was to ignore the questionable lints via Cargo.toml: ``` [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] } ``` This seems to resolve. I also tried bumping the `wasm-bindgen` dep to 0.2.100, which didn't resolve on its own. See related discussion in [0]. [0] rustwasm/wasm-bindgen#4283
Recently, CI jobs started failing on the `rust:lint` step. One suitable workaround was to ignore the questionable lints via Cargo.toml: ``` [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] } ``` This seems to resolve. I also tried bumping the `wasm-bindgen` dep to 0.2.100, which didn't resolve on its own. See related discussion in [0]. [0] rustwasm/wasm-bindgen#4283
Recently, CI jobs started failing on the `rust:lint` step. One suitable workaround was to ignore the questionable lints via Cargo.toml: ``` [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] } ``` This seems to resolve. I also tried bumping the `wasm-bindgen` dep to 0.2.100, which didn't resolve on its own. See related discussion in [0]. [0] rustwasm/wasm-bindgen#4283
Recently, CI jobs started failing on the `rust:lint` step. One suitable workaround was to ignore the questionable lints via Cargo.toml: ``` [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] } ``` This seems to resolve. I also tried bumping the `wasm-bindgen` dep to 0.2.100, which didn't resolve on its own. See related discussion in [0]. [0] rustwasm/wasm-bindgen#4283
version:
wasm-bindgen v0.2.95
Recent rust nightly version enabled by default the
unexpected_cfgs
, which lead to this warning:The text was updated successfully, but these errors were encountered: