We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We use vergen-gitcl to get the latest v* tag and build it into binary, but found it was wrong on Windows, getting the commit sha instead of tags.
v*
we dig into the implementation of vergen-gitcl and found it uses cmd to get the result:
vergen-gitcl
vergen/vergen-gitcl/src/gitcl/mod.rs
Lines 523 to 534 in 367d447
with match_pattern, gitcl will add the --match "v*" as args, notice the quotes within it.
--match "v*"
Lines 640 to 644 in 367d447
but as the cmd lib says, all Windows arguments are passed as a single commandline string:
and we did some experiments:
it seems the current implementation can not get the right tag due to the quotes.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
We use vergen-gitcl to get the latest
v*
tag and build it into binary,but found it was wrong on Windows, getting the commit sha instead of tags.
we dig into the implementation of
vergen-gitcl
and found it uses cmd to get the result:vergen/vergen-gitcl/src/gitcl/mod.rs
Lines 523 to 534 in 367d447
with match_pattern, gitcl will add the
--match "v*"
as args, notice the quotes within it.vergen/vergen-gitcl/src/gitcl/mod.rs
Lines 640 to 644 in 367d447
but as the cmd lib says, all Windows arguments are passed as a single commandline string:
and we did some experiments:
it seems the current implementation can not get the right tag due to the quotes.
The text was updated successfully, but these errors were encountered: