Skip to content

Commit 4f5f35a

Browse files
FahrenbergerFahrenberger
Fahrenberger
authored and
Fahrenberger
committed
For correct behavior, remove password handler when using token authentication.
1 parent 19e2468 commit 4f5f35a

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

v1pysdk/client.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -80,19 +80,19 @@ def __init__(self, address="localhost", instance="VersionOne.Web", username='',
8080
self.logger.setLevel(loglevel)
8181
self.username = username
8282
self.password = password
83-
if token:
84-
self.token = token
83+
self.token = token
8584
self._install_opener()
8685

8786
def _install_opener(self):
8887
base_url = self.build_url('')
89-
password_manager = urllib2.HTTPPasswordMgrWithDefaultRealm()
90-
password_manager.add_password(None, base_url, self.username, self.password)
91-
handlers = [HandlerClass(password_manager) for HandlerClass in AUTH_HANDLERS]
92-
self.opener = urllib2.build_opener(*handlers)
9388
if self.token:
94-
self.opener.addheaders.append(
95-
('Authorization', 'Bearer {token}'.format(token=self.token)))
89+
self.opener = urllib2.build_opener()
90+
self.opener.addheaders.append( ('Authorization', 'Bearer {token}'.format(token=self.token)) )
91+
else:
92+
password_manager = urllib2.HTTPPasswordMgrWithDefaultRealm()
93+
password_manager.add_password(None, base_url, self.username, self.password)
94+
handlers = [HandlerClass(password_manager) for HandlerClass in AUTH_HANDLERS]
95+
self.opener = urllib2.build_opener(*handlers)
9696
self.opener.add_handler(HTTPCookieProcessor())
9797

9898
def http_get(self, url):

v1pysdk/v1meta.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def generate_update_doc(self, newdata):
123123
node.text = str(newvalue).decode('utf-8')
124124
else:
125125
node.text = newvalue
126-
update_doc.append(node)
126+
update_doc.append(node)
127127
return update_doc
128128

129129
def create_asset(self, asset_type_name, newdata):

0 commit comments

Comments
 (0)