Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track proposals in child Safes #2312

Open
iamacook opened this issue Jan 29, 2025 · 0 comments
Open

Track proposals in child Safes #2312

iamacook opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@iamacook
Copy link
Member

Description

Note: this issue could be tracked in a multitude of repositories (here, Safe Transaction Service, Safe{Wallet}) but is only here for simplicity.

As we natively support child Safe Accounts in Safe{Wallet}, we have received report of on-chain none collision. This occurs because children do not track nonces of untrusted transactions - proposals have no signatures.

We should investigate the possibility to track the queue when proposing via a child.

Reproduction steps

  1. Propose >1 transactions in child Safe Accounts
  2. Execute proposals in paren Safe Accounts

Expected behavior

Proposals are visible in child Safe Account queues, preventing proposal at the same nonce.

Additional information

@iamacook iamacook added the bug Something isn't working label Jan 29, 2025
@iamacook iamacook self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant