Skip to content

Commit 62bbc0d

Browse files
committed
improvements from code review
1 parent c2a05a5 commit 62bbc0d

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
export * from './lib/comparison-tool.component';
2-
export * from './lib/comparison-tool.variables';

libs/explorers/services/src/lib/comparison-tool.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export class ComparisonToolService<T> {
3737
filterResultsButtonTooltip: 'Filter results',
3838
showSignificanceControls: true,
3939
viewDetailsTooltip: 'View detailed results',
40-
viewDetailsClick: () => {
40+
viewDetailsClick: (id: string, label: string) => {
4141
return;
4242
},
4343
legendEnabled: true,
@@ -352,7 +352,7 @@ export class ComparisonToolService<T> {
352352
}
353353

354354
handleLazyLoad(event: TableLazyLoadEvent) {
355-
const defaultRowsPerPage = this.viewConfigSignal().rowsPerPage || 10;
355+
const defaultRowsPerPage = this.viewConfigSignal().rowsPerPage;
356356
const { pageNumber, pageSize } = this.helperService.getPaginationParams(
357357
event,
358358
defaultRowsPerPage,

0 commit comments

Comments
 (0)