Skip to content

Commit d541e00

Browse files
author
Zerline
committed
Strip empty list values (eg empty rows) while modfying objects.
1 parent 17f9e4f commit d541e00

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

sage_widget_adapters/combinat/tableau_grid_view_adapter.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ def remove_cell(self, obj, pos, dirty={}):
188188
tl[pos[0]].pop()
189189
if not tl[pos[0]]:
190190
tl.pop()
191+
tl = [r for r in tl if r] # do not keep any empty row before the test
191192
return self._validate(tl)
192193

193194
class SemistandardTableauGridViewAdapter(TableauGridViewAdapter):

sage_widget_adapters/generic_grid_view_adapter.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def get_cell(obj, pos):
194194
def make_dirty(self, l, dirty={}):
195195
r"""
196196
Append 'dirty' values to list 'l'.
197-
Return a list.
197+
Return a list with no empty values.
198198
199199
TESTS ::
200200
@@ -205,6 +205,8 @@ def make_dirty(self, l, dirty={}):
205205
sage: ga.cellzero = 0
206206
sage: ga.make_dirty(t.to_list(), {(1,2):42})
207207
[[1, 2, 5, 6], [3, 7, 42], [4]]
208+
sage: ga.make_dirty(t.to_list(), {(2,0):0})
209+
[[1, 2, 5, 6], [3, 7]]
208210
"""
209211
for p in dirty:
210212
if p[0] < len(l):
@@ -219,7 +221,7 @@ def make_dirty(self, l, dirty={}):
219221
for i in range(p[0] - len(l)):
220222
l.append([])
221223
l.append([dirty[p]])
222-
return l
224+
return [val for val in l if val]
223225

224226
def set_cell(self, obj, pos, val, dirty={}, constructorname=''):
225227
r"""

0 commit comments

Comments
 (0)