Skip to content

Commit 7851798

Browse files
author
Release Manager
committed
gh-39562: Meson: Remove unused build dependencies ppl and fplll <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> Remove ppl and fplll as (build) dependencies according to #39548 (comment) since they are only used via their python wrappers. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #39562 Reported by: Tobias Diez Reviewer(s): Gonzalo Tornaría, Michael Orlitzky
2 parents 73a3d75 + 629e10f commit 7851798

File tree

3 files changed

+2
-7
lines changed

3 files changed

+2
-7
lines changed

pyproject.toml

+1-3
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ host-requires = [
113113
"pkg:generic/eclib",
114114
"pkg:generic/ecm",
115115
"pkg:generic/fflas-ffpack",
116-
"pkg:generic/fplll",
117116
"pkg:generic/flint",
118117
"pkg:generic/libgd",
119118
"pkg:generic/gap",
@@ -143,7 +142,6 @@ host-requires = [
143142
"pkg:generic/pari-galdata",
144143
"pkg:generic/pari-seadata",
145144
"pkg:generic/planarity",
146-
"pkg:generic/ppl",
147145
"pkg:generic/primesieve",
148146
"pkg:generic/primecount",
149147
"pkg:generic/qhull",
@@ -154,10 +152,10 @@ host-requires = [
154152
]
155153

156154
dependencies = [
157-
"pkg:generic/tachyon",
158155
"pkg:generic/sagemath-polytopes-db",
159156
"pkg:generic/sagemath-elliptic-curves",
160157
"pkg:generic/sagemath-graphs",
158+
"pkg:generic/tachyon",
161159
]
162160

163161
[dependency-groups]

src/meson.build

-3
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,8 @@ zlib = dependency('zlib', version: '>=1.2.11')
101101
ec = dependency('eclib', version: '>=20231211')
102102
# Cannot be found via pkg-config
103103
ecm = cc.find_library('ecm')
104-
# Cannot be found via pkg-config
105-
ppl = cc.find_library('ppl')
106104
gmpxx = dependency('gmpxx')
107105
fflas = dependency('fflas-ffpack', version: '>=2.5.0')
108-
fplll = dependency('fplll')
109106
givaro = dependency('givaro', version: '>=4.2.0')
110107
linbox = dependency('linbox', required: false, version: '>=1.7.0')
111108
if not linbox.found()

src/sage/libs/linbox/meson.build

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ foreach name, pyx : extension_data_cpp
2020
install: true,
2121
override_options: ['cython_language=cpp'],
2222
include_directories: [inc_flint],
23-
dependencies: [py_dep, blas, flint, fplll, givaro, gmp, gmpxx, linbox],
23+
dependencies: [py_dep, blas, flint, givaro, gmp, gmpxx, linbox],
2424
)
2525
endforeach
2626

0 commit comments

Comments
 (0)