Skip to content

Commit cc9d9b1

Browse files
committed
add tuple typing to gens methods in algebras
1 parent dc99dc8 commit cc9d9b1

25 files changed

+38
-38
lines changed

src/sage/algebras/askey_wilson.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ def build_monomial(g):
348348
return Family(A, build_monomial)
349349

350350
@cached_method
351-
def gens(self):
351+
def gens(self) -> tuple:
352352
r"""
353353
Return the generators of ``self``.
354354

src/sage/algebras/clifford_algebra.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -787,7 +787,7 @@ def gen(self, i):
787787
"""
788788
return self._from_dict({FrozenBitset((i,)): self.base_ring().one()}, remove_zeros=False)
789789

790-
def algebra_generators(self):
790+
def algebra_generators(self) -> Family:
791791
"""
792792
Return the algebra generators of ``self``.
793793
@@ -801,7 +801,7 @@ def algebra_generators(self):
801801
d = {x: self.gen(i) for i, x in enumerate(self.variable_names())}
802802
return Family(self.variable_names(), lambda x: d[x])
803803

804-
def gens(self):
804+
def gens(self) -> tuple:
805805
r"""
806806
Return the generators of ``self`` (as an algebra).
807807

src/sage/algebras/cluster_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2094,7 +2094,7 @@ def retract(self, x):
20942094
return self(x)
20952095

20962096
@cached_method
2097-
def gens(self):
2097+
def gens(self) -> tuple:
20982098
r"""
20992099
Return the list of initial cluster variables and coefficients of ``self``.
21002100

src/sage/algebras/down_up_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ def algebra_generators(self):
319319
return Family({'d': d, 'u': u})
320320

321321
@cached_method
322-
def gens(self):
322+
def gens(self) -> tuple:
323323
r"""
324324
Return the generators of ``self``.
325325

src/sage/algebras/free_zinbiel_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ def change_ring(self, R):
343343
return FreeZinbielAlgebra(R, n=len(A), names=A, side=self._side)
344344

345345
@cached_method
346-
def gens(self):
346+
def gens(self) -> tuple:
347347
"""
348348
Return the generators of ``self``.
349349

src/sage/algebras/hecke_algebras/ariki_koike_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ def cyclotomic_parameters(self):
532532
u = cyclotomic_parameters
533533

534534
@cached_method
535-
def gens(self):
535+
def gens(self) -> tuple:
536536
r"""
537537
Return the generators of ``self``.
538538

src/sage/algebras/hecke_algebras/cubic_hecke_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1415,7 +1415,7 @@ def algebra_generators(self):
14151415
from sage.sets.family import Family
14161416
return Family(self._cubic_braid_group.gens(), self.monomial)
14171417

1418-
def gens(self):
1418+
def gens(self) -> tuple:
14191419
r"""
14201420
Return the generators of ``self``.
14211421

src/sage/algebras/jordan_algebra.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ def basis(self):
328328
algebra_generators = basis
329329

330330
# TODO: Keep this until we can better handle R.<...> shorthand
331-
def gens(self):
331+
def gens(self) -> tuple:
332332
"""
333333
Return the generators of ``self``.
334334
@@ -763,7 +763,7 @@ def basis(self):
763763

764764
algebra_generators = basis
765765

766-
def gens(self):
766+
def gens(self) -> tuple:
767767
"""
768768
Return the generators of ``self``.
769769
@@ -1316,7 +1316,7 @@ def basis(self):
13161316

13171317
algebra_generators = basis
13181318

1319-
def gens(self):
1319+
def gens(self) -> tuple:
13201320
"""
13211321
Return the generators of ``self``.
13221322

src/sage/algebras/letterplace/free_algebra_letterplace.pyx

+1-1
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ cdef class FreeAlgebra_letterplace(Parent):
348348
p *= self._current_ring.gen(j)
349349
return FreeAlgebraElement_letterplace(self, p)
350350

351-
def gens(self):
351+
def gens(self) -> tuple:
352352
"""
353353
Return the tuple of generators.
354354

src/sage/algebras/lie_algebras/classical_lie_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -2170,7 +2170,7 @@ def _part_generators(self, positive=False):
21702170
return Family(I, d.__getitem__)
21712171

21722172
@cached_method
2173-
def gens(self):
2173+
def gens(self) -> tuple:
21742174
r"""
21752175
Return the generators of ``self`` in the order of `e_i`, `f_i`,
21762176
and `h_i`.

src/sage/algebras/lie_algebras/free_lie_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,7 @@ def lie_algebra_generators(self):
419419
"""
420420
return self.Lyndon().lie_algebra_generators()
421421

422-
def gens(self):
422+
def gens(self) -> tuple:
423423
"""
424424
Return the generators of ``self`` in the Lyndon basis.
425425

src/sage/algebras/lie_algebras/heisenberg.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66
- Travis Scrimshaw (2013-08-13): Initial version
77
"""
88

9-
#*****************************************************************************
9+
# ***************************************************************************
1010
# Copyright (C) 2013-2017 Travis Scrimshaw <tcscrims at gmail.com>
1111
#
1212
# This program is free software: you can redistribute it and/or modify
1313
# it under the terms of the GNU General Public License as published by
1414
# the Free Software Foundation, either version 2 of the License, or
1515
# (at your option) any later version.
16-
# http://www.gnu.org/licenses/
17-
#*****************************************************************************
16+
# https://www.gnu.org/licenses/
17+
# ***************************************************************************
1818

1919
from sage.misc.cachefunc import cached_method
2020
from sage.structure.indexed_generators import IndexedGenerators
@@ -234,7 +234,7 @@ def n(self):
234234
return self._n
235235

236236
@cached_method
237-
def gens(self):
237+
def gens(self) -> tuple:
238238
"""
239239
Return the Lie algebra generators of ``self``.
240240

src/sage/algebras/lie_algebras/lie_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ def lie_algebra_generators(self):
823823
return Family(self._indices, self.monomial, name="monomial map")
824824

825825
@cached_method
826-
def gens(self):
826+
def gens(self) -> tuple:
827827
"""
828828
Return a tuple whose entries are the generators for this
829829
object, in some order.

src/sage/algebras/lie_algebras/subalgebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ def retract(self, X):
646646

647647
return self.element_class(self, X)
648648

649-
def gens(self):
649+
def gens(self) -> tuple:
650650
r"""
651651
Return the generating set of ``self``.
652652

src/sage/algebras/lie_algebras/verma_module.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ def highest_weight_vector(self):
356356
return self._from_dict({self._indices.one(): one},
357357
remove_zeros=False, coerce=False)
358358

359-
def gens(self):
359+
def gens(self) -> tuple:
360360
r"""
361361
Return the generators of ``self`` as a `U(\mathfrak{g})`-module.
362362

src/sage/algebras/octonion_algebra.pyx

+1-1
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,7 @@ class OctonionAlgebra(UniqueRepresentation, Parent):
952952
return 0
953953

954954
@cached_method
955-
def gens(self):
955+
def gens(self) -> tuple:
956956
r"""
957957
Return the generators of ``self``.
958958

src/sage/algebras/q_commuting_polynomials.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def gen(self, i):
147147
return self.monomial(self._indices.gen(i))
148148

149149
@cached_method
150-
def gens(self):
150+
def gens(self) -> tuple:
151151
r"""
152152
Return the generators of ``self``.
153153

src/sage/algebras/q_system.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ def algebra_generators(self):
382382
d = {a: self.Q(a, 1) for a in I}
383383
return Family(I, d.__getitem__)
384384

385-
def gens(self):
385+
def gens(self) -> tuple:
386386
"""
387387
Return the generators of ``self``.
388388

src/sage/algebras/quantum_clifford.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ def algebra_generators(self):
301301
return Family(sorted(d), lambda i: d[i])
302302

303303
@cached_method
304-
def gens(self):
304+
def gens(self) -> tuple:
305305
r"""
306306
Return the generators of ``self``.
307307

src/sage/algebras/quantum_groups/quantum_group_gap.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ def zero(self):
500500
return self.element_class(self, self._libgap.ZeroImmutable())
501501

502502
@cached_method
503-
def gens(self):
503+
def gens(self) -> tuple:
504504
"""
505505
Return the generators of ``self``.
506506

src/sage/algebras/quantum_matrix_coordinate_algebra.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ def one_basis(self):
188188
return self._indices.one()
189189

190190
@cached_method
191-
def gens(self):
191+
def gens(self) -> tuple:
192192
r"""
193193
Return the generators of ``self`` as a tuple.
194194
@@ -586,7 +586,7 @@ def m(self):
586586
return self._m
587587

588588
@cached_method
589-
def algebra_generators(self):
589+
def algebra_generators(self) -> Family:
590590
"""
591591
Return the algebra generators of ``self``.
592592

src/sage/algebras/quatalg/quaternion_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1694,7 +1694,7 @@ def one(self):
16941694
"""
16951695
return self.quaternion_algebra().one()
16961696

1697-
def gens(self):
1697+
def gens(self) -> tuple:
16981698
"""
16991699
Return generators for ``self``.
17001700

src/sage/algebras/steenrod/steenrod_algebra.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -452,12 +452,13 @@
452452
# Distributed under the terms of the GNU General Public License (GPL)
453453
# ****************************************************************************
454454

455-
from sage.combinat.free_module import CombinatorialFreeModule
456-
from sage.misc.lazy_attribute import lazy_attribute
457-
from sage.misc.cachefunc import cached_method
455+
from sage.categories.homset import Hom
458456
from sage.categories.modules_with_basis import ModulesWithBasis
459457
from sage.categories.tensor import tensor
460-
from sage.categories.homset import Hom
458+
from sage.combinat.free_module import CombinatorialFreeModule
459+
from sage.misc.cachefunc import cached_method
460+
from sage.misc.lazy_attribute import lazy_attribute
461+
from sage.sets.family import Family
461462

462463
######################################################
463464
# the main class
@@ -2619,7 +2620,7 @@ def ngens(self):
26192620
return sum(self._profile)
26202621
return sum(self._profile[0]) + len([a for a in self._profile[1] if a == 2])
26212622

2622-
def gens(self):
2623+
def gens(self) -> Family:
26232624
r"""
26242625
Family of generators for this algebra.
26252626
@@ -2676,7 +2677,6 @@ def gens(self):
26762677
sage: SteenrodAlgebra(p=5, profile=[[2,1], [2,2,2]]).algebra_generators()
26772678
Family (Q_0, P(1), P(5))
26782679
"""
2679-
from sage.sets.family import Family
26802680
from sage.sets.non_negative_integers import NonNegativeIntegers
26812681
from sage.rings.infinity import Infinity
26822682
n = self.ngens()

src/sage/algebras/yangian.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -832,13 +832,13 @@ def gen(self, r, i=None, j=None):
832832
0
833833
"""
834834
if i is None and j is None:
835-
r,i,j = r
835+
r, i, j = r
836836
if r > self._level:
837837
return self.zero()
838838
return Yangian.gen(self, r, i, j)
839839

840840
@cached_method
841-
def gens(self):
841+
def gens(self) -> tuple:
842842
"""
843843
Return the generators of ``self``.
844844

src/sage/algebras/yokonuma_hecke_algebra.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ def algebra_generators(self):
252252
return Family(sorted(d), lambda i: d[i])
253253

254254
@cached_method
255-
def gens(self):
255+
def gens(self) -> tuple:
256256
"""
257257
Return the generators of ``self``.
258258

0 commit comments

Comments
 (0)