Skip to content

Commit 80ebbe7

Browse files
committed
tests: Apple clang issues warning on C++11 features
$ cat /tmp/foo.cc using foo = int; foo f; $ clang++ -Wc++11-extensions -c /tmp/foo.cc /tmp/foo.cc:1:13: warning: alias declarations are a C++11 extension [-Wc++11-extensions] using foo = int; ^ 1 warning generated. $ clang++ --version Apple clang version 11.0.0 (clang-1100.0.33.17) Target: x86_64-apple-darwin18.7.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin * tests/local.at (AT_COMPILE_CXX): Make sure -std=c++11 is passed when running glr2.cc. It may be overridden by another flag in CXXFLAGS afterwards.
1 parent 028df02 commit 80ebbe7

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

tests/headers.at

+4
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,11 @@ AT_PERL_CHECK([[-n -0777 -e '
386386
# Do this late, so that other checks have been performed.
387387
AT_SKIP_IF_CANNOT_LINK_C_AND_CXX
388388

389+
# The header generated by glr2.cc requires C++11. Push the options to
390+
# prepare AT_COMPILE_CXX.
391+
AT_BISON_OPTION_PUSHDEFS([%skeleton "glr2.cc"])
389392
AT_COMPILE_CXX([parser], [[x[1-9a-d].o -DCC_IS_CXX=$CC_IS_CXX main.cc]])
393+
AT_BISON_OPTION_POPDEFS
390394
AT_PARSER_CHECK([parser], [0], [[expout]])
391395

392396
m4_popdef([AT_TEST])

tests/local.at

+7-1
Original file line numberDiff line numberDiff line change
@@ -1358,13 +1358,19 @@ AT_CHECK(m4_join([ ],
13581358
# If OUTPUT does not contain '.', assume that we are linking too,
13591359
# otherwise pass "-c"; this is a hack. The default SOURCES is OUTPUT
13601360
# with trailing ".o" removed, and ".cc" appended.
1361+
#
1362+
# glr2.cc require C++11.
13611363
m4_define([AT_COMPILE_CXX],
13621364
[AT_KEYWORDS([c++])
13631365
AT_SKIP_IF([[! $BISON_CXX_WORKS]])
13641366
m4_ifdef([AT_GLR2_CC_IF],
13651367
[AT_GLR2_CC_IF([AT_SKIP_IF([[test x"$CXX11_CXXFLAGS" == x]])])])
13661368
AT_CHECK(m4_join([ ],
1367-
[$CXX $CXXFLAGS $CPPFLAGS $3],
1369+
[$CXX],
1370+
[$CPPFLAGS],
1371+
[m4_ifdef([AT_GLR2_CC_IF], [AT_GLR2_CC_IF([$CXX11_CXXFLAGS])])],
1372+
[$CXXFLAGS],
1373+
[$3],
13681374
[m4_bmatch([$1], [[.]], [-c], [$LDFLAGS])],
13691375
[-o $1],
13701376
[m4_default([$2], [m4_bpatsubst([$1], [\.o$]).cc])],

0 commit comments

Comments
 (0)