Skip to content

Commit 29e3c8a

Browse files
committed
Make developer mode optional
1 parent d26d206 commit 29e3c8a

File tree

3 files changed

+26
-5
lines changed

3 files changed

+26
-5
lines changed

src/plugin/plugin.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@
4444
#include "alarmtonemodel.h"
4545
#include "displaysettings.h"
4646
#include "aboutsettings.h"
47+
#ifdef DEVELOPER_MODE_ENABLED
4748
#include "developermodesettings.h"
49+
#endif
4850
#include "batterystatus.h"
4951
#include "diskusage.h"
5052
#include "partitionmodel.h"
@@ -106,10 +108,12 @@ class SystemSettingsPlugin : public QQmlExtensionPlugin
106108
qmlRegisterType<AboutSettings>(uri, 1, 0, "AboutSettings");
107109
qmlRegisterType<PartitionModel>(uri, 1, 0, "PartitionModel");
108110
qRegisterMetaType<Partition>("Partition");
111+
#ifdef DEVELOPER_MODE_ENABLED
109112
qmlRegisterType<DeveloperModeSettings>(uri, 1, 0, "DeveloperModeSettings");
113+
qRegisterMetaType<DeveloperModeSettings::Status>("DeveloperModeSettings::Status");
114+
#endif
110115
qmlRegisterType<CertificateModel>(uri, 1, 0, "CertificateModel");
111116
qmlRegisterSingletonType<SettingsVpnModel>(uri, 1, 0, "SettingsVpnModel", api_factory<SettingsVpnModel>);
112-
qRegisterMetaType<DeveloperModeSettings::Status>("DeveloperModeSettings::Status");
113117
qmlRegisterType<BatteryStatus>(uri, 1, 0, "BatteryStatus");
114118
qmlRegisterType<DiskUsage>(uri, 1, 0, "DiskUsage");
115119
qmlRegisterType<LocationSettings>(uri, 1, 0, "LocationSettings");

src/plugin/plugin.pro

+6-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@ CONFIG += qt plugin c++11 hide_symbols link_pkgconfig
66
QT += qml dbus network
77
QT -= gui
88

9-
PKGCONFIG += profile usb-moded-qt5 libsailfishkeyprovider connman-qt5 packagekitqt5
9+
PKGCONFIG += profile usb-moded-qt5 libsailfishkeyprovider connman-qt5
10+
11+
DEVMODE {
12+
PKGCONFIG += packagekitqt5
13+
DEFINES += DEVELOPER_MODE_ENABLED
14+
}
1015

1116
target.path = $$[QT_INSTALL_QML]/$$PLUGIN_IMPORT_PATH
1217
INSTALLS += target

src/src.pro

+15-3
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,18 @@ QT -= gui
77

88
CONFIG += c++11 hide_symbols link_pkgconfig
99
PKGCONFIG += profile mlite5 mce timed-qt5 blkid libcrypto libsailfishkeyprovider connman-qt5 glib-2.0
10-
PKGCONFIG += ssu-sysinfo nemodbus packagekitqt5 libsystemd sailfishusermanager sailfishaccesscontrol
10+
11+
PKGCONFIG += ssu-sysinfo nemodbus libsystemd sailfishusermanager sailfishaccesscontrol
1112
PKGCONFIG += qofono-qt5
1213

14+
CONFIG(disableDevmode) {
15+
warning("Developer mode plugin disabled")
16+
} else {
17+
message("Developer mode plugin enabled")
18+
PKGCONFIG += packagekitqt5
19+
DEFINES += DEVELOPER_MODE_ENABLED
20+
}
21+
1322
system($$[QT_INSTALL_BINS]/qdbusxml2cpp -p mceiface.h:mceiface.cpp mce.xml)
1423

1524
SOURCES += \
@@ -24,7 +33,6 @@ SOURCES += \
2433
displaysettings.cpp \
2534
aboutsettings.cpp \
2635
certificatemodel.cpp \
27-
developermodesettings.cpp \
2836
batterystatus.cpp \
2937
diskusage.cpp \
3038
diskusage_impl.cpp \
@@ -53,7 +61,6 @@ PUBLIC_HEADERS = \
5361
aboutsettings.h \
5462
certificatemodel.h \
5563
settingsvpnmodel.h \
56-
developermodesettings.h \
5764
batterystatus.h \
5865
udisks2block_p.h \
5966
udisks2defines.h \
@@ -86,6 +93,11 @@ HEADERS += \
8693
udisks2monitor_p.h \
8794
userinfo_p.h
8895

96+
CONFIG(DEVELOPER_MODE_ENABLED) {
97+
SOURCES += developermodesettings.cpp
98+
PUBLIC_HEADERS += developermodesettings.h
99+
}
100+
89101
DEFINES += \
90102
SYSTEMSETTINGS_BUILD_LIBRARY
91103

0 commit comments

Comments
 (0)