Skip to content

Commit 3e07256

Browse files
committed
Make developer mode optional
1 parent cdd4a33 commit 3e07256

File tree

3 files changed

+25
-5
lines changed

3 files changed

+25
-5
lines changed

src/plugin/plugin.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@
4444
#include "alarmtonemodel.h"
4545
#include "displaysettings.h"
4646
#include "aboutsettings.h"
47+
#ifdef DEVELOPER_MODE_ENABLED
4748
#include "developermodesettings.h"
49+
#endif
4850
#include "batterystatus.h"
4951
#include "diskusage.h"
5052
#include "partitionmodel.h"
@@ -106,10 +108,12 @@ class SystemSettingsPlugin : public QQmlExtensionPlugin
106108
qmlRegisterType<AboutSettings>(uri, 1, 0, "AboutSettings");
107109
qmlRegisterType<PartitionModel>(uri, 1, 0, "PartitionModel");
108110
qRegisterMetaType<Partition>("Partition");
111+
#ifdef DEVELOPER_MODE_ENABLED
109112
qmlRegisterType<DeveloperModeSettings>(uri, 1, 0, "DeveloperModeSettings");
113+
qRegisterMetaType<DeveloperModeSettings::Status>("DeveloperModeSettings::Status");
114+
#endif
110115
qmlRegisterType<CertificateModel>(uri, 1, 0, "CertificateModel");
111116
qmlRegisterSingletonType<SettingsVpnModel>(uri, 1, 0, "SettingsVpnModel", api_factory<SettingsVpnModel>);
112-
qRegisterMetaType<DeveloperModeSettings::Status>("DeveloperModeSettings::Status");
113117
qmlRegisterType<BatteryStatus>(uri, 1, 0, "BatteryStatus");
114118
qmlRegisterType<DiskUsage>(uri, 1, 0, "DiskUsage");
115119
qmlRegisterType<LocationSettings>(uri, 1, 0, "LocationSettings");

src/plugin/plugin.pro

+6-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@ CONFIG += qt plugin c++11 hide_symbols link_pkgconfig
66
QT += qml dbus network
77
QT -= gui
88

9-
PKGCONFIG += profile usb-moded-qt5 libsailfishkeyprovider connman-qt5 packagekitqt5
9+
PKGCONFIG += profile usb-moded-qt5 libsailfishkeyprovider connman-qt5
10+
11+
packagesExist(packagekitqt5) {
12+
PKGCONFIG += packagekitqt5
13+
DEFINES += DEVELOPER_MODE_ENABLED
14+
}
1015

1116
target.path = $$[QT_INSTALL_QML]/$$PLUGIN_IMPORT_PATH
1217
INSTALLS += target

src/src.pro

+14-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,15 @@ QT -= gui
77

88
CONFIG += c++11 hide_symbols link_pkgconfig
99
PKGCONFIG += profile mlite5 mce timed-qt5 blkid libcrypto libsailfishkeyprovider connman-qt5 glib-2.0
10-
PKGCONFIG += ssu-sysinfo nemodbus packagekitqt5 libsystemd sailfishusermanager sailfishaccesscontrol
10+
PKGCONFIG += ssu-sysinfo nemodbus libsystemd sailfishusermanager sailfishaccesscontrol
11+
12+
packagesExist(packagekitqt5) {
13+
message("Developer mode plugin enabled")
14+
PKGCONFIG += packagekitqt5
15+
DEFINES += DEVELOPER_MODE_ENABLED
16+
} else {
17+
warning("Developer mode plugin disabled")
18+
}
1119

1220
system($$[QT_INSTALL_BINS]/qdbusxml2cpp -p mceiface.h:mceiface.cpp mce.xml)
1321

@@ -23,7 +31,6 @@ SOURCES += \
2331
displaysettings.cpp \
2432
aboutsettings.cpp \
2533
certificatemodel.cpp \
26-
developermodesettings.cpp \
2734
batterystatus.cpp \
2835
diskusage.cpp \
2936
diskusage_impl.cpp \
@@ -52,7 +59,6 @@ PUBLIC_HEADERS = \
5259
aboutsettings.h \
5360
certificatemodel.h \
5461
settingsvpnmodel.h \
55-
developermodesettings.h \
5662
batterystatus.h \
5763
udisks2block_p.h \
5864
udisks2defines.h \
@@ -85,6 +91,11 @@ HEADERS += \
8591
udisks2monitor_p.h \
8692
userinfo_p.h
8793

94+
CONFIG(DEVELOPER_MODE_ENABLED) {
95+
SOURCES += developermodesettings.cpp
96+
PUBLIC_HEADERS += developermodesettings.h
97+
}
98+
8899
DEFINES += \
89100
SYSTEMSETTINGS_BUILD_LIBRARY
90101

0 commit comments

Comments
 (0)