Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler failure: marked ‘override’, but does not override #173

Open
kan-ibal opened this issue Nov 2, 2024 · 1 comment
Open

Compiler failure: marked ‘override’, but does not override #173

kan-ibal opened this issue Nov 2, 2024 · 1 comment

Comments

@kan-ibal
Copy link

kan-ibal commented Nov 2, 2024

SDK 3.11.1
target 4.6.0.13

../../../sailfish-components-webview-1.6.0/import/webview/rawwebview.cpp:40:13: error: ‘quint32 SailfishOS::WebView::ViewCreator::createView(const quint32&, const uintptr_t&, bool)’ marked ‘override’, but does not override
   40 |     quint32 createView(const quint32 &parentId, const uintptr_t &parentBrowsingContext, const bool hidden = false) override;
      |             ^~~~~~~~~~
compilation terminated due to -Wfatal-errors.
make[2]: *** [Makefile:452: rawwebview.o] Error 1

@mlehtima
Copy link
Contributor

mlehtima commented Nov 2, 2024

Versions 1.6.0 and above need gecko ESR91 from https://github.com/sailfishos/gecko-dev/ (latest master branch) which is not in 4.6.0 target but will be in 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants