Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer - Custom "Loading" Component #245

Open
joseph-bayer opened this issue Jan 29, 2025 · 3 comments
Open

Viewer - Custom "Loading" Component #245

joseph-bayer opened this issue Jan 29, 2025 · 3 comments

Comments

@joseph-bayer
Copy link
Contributor

joseph-bayer commented Jan 29, 2025

I'd like to display a custom component instead of the "Loading" text that displays while the manifest is fetched & loaded into React.Context (code here)

  1. Is this something you'd be interested in me implementing?
  2. If so, what solution would be acceptable? For example, we could pass in a react component into the config and display that instead of "Loading" (but only when that config value is populated)

EDIT: Support for a custom loading component is now available! Based on the conversation in this pull request, I'll be updating the default loading text to be a skeleton instead.

@mathewjordan
Copy link
Member

Hey @joseph-bayer this would be a great addition. That Loading text has always bothered me a bit. Updating this default component and setting up a way to pass in a custom React component through the configuration options seems like a great step forward.

We're open to PRs and if our configuration models make sense and you have thoughts on how this could work, please contribute forward!

@mathewjordan
Copy link
Member

@joseph-bayer I'll leave it up to whether to amend this issue or create a new one for the update of the default loader using a skeleton.

@joseph-bayer
Copy link
Contributor Author

Hey @mathewjordan - we can amend this issue for the loading skeleton.

Sorry for the delay! I'm still working on it, but have been super busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants