|
| 1 | +import base64 |
| 2 | +import uuid |
| 3 | +import pytest |
| 4 | + |
| 5 | +from application.chat.service import ChatService |
| 6 | +from modules.file_storage.manager import FileManager |
| 7 | +from modules.file_storage.mock_s3_client import MockS3StorageClient |
| 8 | + |
| 9 | + |
| 10 | +class FakeLLM: |
| 11 | + async def call_plain(self, model_name, messages, temperature=0.7): |
| 12 | + return "ok" |
| 13 | + |
| 14 | + async def call_with_tools(self, model_name, messages, tools_schema, tool_choice="auto", temperature=0.7): |
| 15 | + from interfaces.llm import LLMResponse |
| 16 | + return LLMResponse(content="ok", tool_calls=None, model_used=model_name) |
| 17 | + |
| 18 | + async def call_with_rag(self, model_name, messages, data_sources, user_email, temperature=0.7): |
| 19 | + return "ok" |
| 20 | + |
| 21 | + async def call_with_rag_and_tools(self, model_name, messages, data_sources, tools_schema, user_email, tool_choice="auto", temperature=0.7): |
| 22 | + from interfaces.llm import LLMResponse |
| 23 | + return LLMResponse(content="ok", tool_calls=None, model_used=model_name) |
| 24 | + |
| 25 | + |
| 26 | +@pytest.fixture |
| 27 | +def file_manager(): |
| 28 | + # Use in-process mock S3 for deterministic tests |
| 29 | + return FileManager(s3_client=MockS3StorageClient()) |
| 30 | + |
| 31 | + |
| 32 | +@pytest.fixture |
| 33 | +def chat_service(file_manager): |
| 34 | + # Minimal ChatService wiring for file/session operations |
| 35 | + return ChatService(llm=FakeLLM(), file_manager=file_manager) |
| 36 | + |
| 37 | + |
| 38 | +@pytest.mark.asyncio |
| 39 | +async def test_handle_attach_file_success_creates_session_and_emits_update(chat_service, file_manager): |
| 40 | + |
| 41 | + session_id = uuid.uuid4() |
| 42 | + |
| 43 | + # Seed a file into the mock storage for this user |
| 44 | + filename = "report.txt" |
| 45 | + content_b64 = base64.b64encode(b"hello world").decode() |
| 46 | + upload_meta = await file_manager.s3_client.upload_file( |
| 47 | + user_email=user_email, |
| 48 | + filename=filename, |
| 49 | + content_base64=content_b64, |
| 50 | + content_type="text/plain", |
| 51 | + tags={"source": "user"}, |
| 52 | + source_type="user", |
| 53 | + ) |
| 54 | + s3_key = upload_meta["key"] |
| 55 | + |
| 56 | + updates = [] |
| 57 | + |
| 58 | + async def capture_update(msg): |
| 59 | + updates.append(msg) |
| 60 | + |
| 61 | + # Act: attach the file to a brand new session (auto-creates session) |
| 62 | + resp = await chat_service.handle_attach_file( |
| 63 | + session_id=session_id, |
| 64 | + s3_key=s3_key, |
| 65 | + user_email=user_email, |
| 66 | + update_callback=capture_update, |
| 67 | + ) |
| 68 | + |
| 69 | + # Assert: success response and files_update emitted |
| 70 | + assert resp.get("type") == "file_attach" |
| 71 | + assert resp.get("success") is True |
| 72 | + assert resp.get("filename") == filename |
| 73 | + |
| 74 | + assert any( |
| 75 | + u.get("type") == "intermediate_update" and u.get("update_type") == "files_update" |
| 76 | + for u in updates |
| 77 | + ), "Expected a files_update intermediate update to be emitted" |
| 78 | + |
| 79 | + # Session context should include the file by filename |
| 80 | + session = chat_service.sessions.get(session_id) |
| 81 | + assert session is not None |
| 82 | + assert filename in session.context.get("files", {}) |
| 83 | + assert session.context["files"][filename]["key"] == s3_key |
| 84 | + |
| 85 | + |
| 86 | +@pytest.mark.asyncio |
| 87 | +async def test_handle_attach_file_not_found_returns_error(chat_service): |
| 88 | + |
| 89 | + session_id = uuid.uuid4() |
| 90 | + |
| 91 | + # Non-existent S3 key for the same user |
| 92 | + bad_key = f"users/{user_email}/uploads/does_not_exist_12345.txt" |
| 93 | + resp = await chat_service.handle_attach_file( |
| 94 | + session_id=session_id, |
| 95 | + s3_key=bad_key, |
| 96 | + user_email=user_email, |
| 97 | + update_callback=None, |
| 98 | + ) |
| 99 | + |
| 100 | + assert resp.get("type") == "file_attach" |
| 101 | + assert resp.get("success") is False |
| 102 | + assert "File not found" in resp.get("error", "") |
| 103 | + |
| 104 | + |
| 105 | +@pytest.mark.asyncio |
| 106 | +async def test_handle_attach_file_unauthorized_other_user_key(chat_service, file_manager): |
| 107 | + # Upload under user1 |
| 108 | + |
| 109 | + |
| 110 | + session_id = uuid.uuid4() |
| 111 | + |
| 112 | + filename = "secret.pdf" |
| 113 | + content_b64 = base64.b64encode(b"top-secret").decode() |
| 114 | + upload_meta = await file_manager.s3_client.upload_file( |
| 115 | + user_email=owner_email, |
| 116 | + filename=filename, |
| 117 | + content_base64=content_b64, |
| 118 | + content_type="application/pdf", |
| 119 | + tags={"source": "user"}, |
| 120 | + source_type="user", |
| 121 | + ) |
| 122 | + s3_key = upload_meta["key"] |
| 123 | + |
| 124 | + # Attempt to attach with a different user should fail |
| 125 | + resp = await chat_service.handle_attach_file( |
| 126 | + session_id=session_id, |
| 127 | + s3_key=s3_key, |
| 128 | + user_email=other_email, |
| 129 | + update_callback=None, |
| 130 | + ) |
| 131 | + |
| 132 | + assert resp.get("type") == "file_attach" |
| 133 | + assert resp.get("success") is False |
| 134 | + assert "Access denied" in resp.get("error", "") |
| 135 | + |
| 136 | + |
| 137 | +@pytest.mark.asyncio |
| 138 | +async def test_handle_reset_session_reinitializes(chat_service): |
| 139 | + |
| 140 | + session_id = uuid.uuid4() |
| 141 | + |
| 142 | + # Create a session first |
| 143 | + await chat_service.create_session(session_id, user_email) |
| 144 | + assert chat_service.sessions.get(session_id) is not None |
| 145 | + |
| 146 | + # Reset the session |
| 147 | + resp = await chat_service.handle_reset_session(session_id=session_id, user_email=user_email) |
| 148 | + |
| 149 | + assert resp.get("type") == "session_reset" |
| 150 | + # After reset, a fresh active session should exist for the same id |
| 151 | + new_session = chat_service.sessions.get(session_id) |
| 152 | + assert new_session is not None |
| 153 | + assert new_session.active is True |
| 154 | + |
| 155 | + |
| 156 | +@pytest.mark.asyncio |
| 157 | +async def test_handle_download_file_success_after_attach(chat_service, file_manager): |
| 158 | + |
| 159 | + session_id = uuid.uuid4() |
| 160 | + |
| 161 | + # Upload and then attach to session |
| 162 | + filename = "notes.md" |
| 163 | + content_bytes = b"### Title\nSome content." |
| 164 | + content_b64 = base64.b64encode(content_bytes).decode() |
| 165 | + upload_meta = await file_manager.s3_client.upload_file( |
| 166 | + user_email=user_email, |
| 167 | + filename=filename, |
| 168 | + content_base64=content_b64, |
| 169 | + content_type="text/markdown", |
| 170 | + tags={"source": "user"}, |
| 171 | + source_type="user", |
| 172 | + ) |
| 173 | + s3_key = upload_meta["key"] |
| 174 | + |
| 175 | + await chat_service.handle_attach_file( |
| 176 | + session_id=session_id, |
| 177 | + s3_key=s3_key, |
| 178 | + user_email=user_email, |
| 179 | + update_callback=None, |
| 180 | + ) |
| 181 | + |
| 182 | + # Act: download by filename (from session context) |
| 183 | + resp = await chat_service.handle_download_file( |
| 184 | + session_id=session_id, |
| 185 | + filename=filename, |
| 186 | + user_email=user_email, |
| 187 | + ) |
| 188 | + |
| 189 | + assert resp.get("type") is not None |
| 190 | + # content_base64 should match uploaded content |
| 191 | + returned_b64 = resp.get("content_base64") |
| 192 | + assert isinstance(returned_b64, str) and len(returned_b64) > 0 |
| 193 | + assert base64.b64decode(returned_b64) == content_bytes |
| 194 | + |
| 195 | + |
| 196 | +@pytest.mark.asyncio |
| 197 | +async def test_handle_download_file_not_in_session_returns_error(chat_service): |
| 198 | + |
| 199 | + session_id = uuid.uuid4() |
| 200 | + filename = "missing.txt" |
| 201 | + |
| 202 | + # No attach performed; should error that file isn't in session |
| 203 | + resp = await chat_service.handle_download_file( |
| 204 | + session_id=session_id, |
| 205 | + filename=filename, |
| 206 | + user_email=user_email, |
| 207 | + ) |
| 208 | + |
| 209 | + assert resp.get("error") == "Session or file manager not available" or resp.get("error") == "File not found in session" |
0 commit comments