Fix some story and mediaretriever bug

Author: ammargitham

app/src/main/java/awais/instagrabber/utils/ResponseBodyUtils.java

@@ -2,7 +2,6 @@
 
 import android.net.Uri;
 import android.util.Log;
-import android.util.Pair;
 
 import androidx.annotation.Nullable;
 
@@ -1042,7 +1041,7 @@ else if (backupSwipeUpUrl != null && backupSwipeUpUrl.startsWith("http"))
                         tappableObject.getString("question"),
                         tappableObject.getString("emoji"),
                         tappableObject.getBoolean("viewer_can_vote"),
-                        tappableObject.getDouble("slider_vote_average"),
+                        tappableObject.optDouble("slider_vote_average"),
                         tappableObject.getInt("slider_vote_count"),
                         tappableObject.optDouble("viewer_vote")
                 ));

app/src/main/java/awais/instagrabber/webservices/StoriesService.java

@@ -193,8 +193,7 @@ private void parseStoriesBody(final String body, final ServiceCallback<List<Feed
                             node.getInt("media_count"),
                             false,
                             node.optBoolean("has_besties_media")));
-                }
-                catch (Exception e) {} // to cover promotional reels with non-long user pk's
+                } catch (Exception e) {} // to cover promotional reels with non-long user pk's
             }
             final JSONArray broadcasts = new JSONObject(body).getJSONArray("broadcasts");
             for (int i = 0; i < broadcasts.length(); ++i) {
@@ -371,7 +370,8 @@ public void getUserStory(final StoryViewerOptions options,
         final String url = buildUrl(options);
         final Call<String> userStoryCall = repository.getUserStory(url);
         final boolean isLocOrHashtag = options.getType() == StoryViewerOptions.Type.LOCATION || options.getType() == StoryViewerOptions.Type.HASHTAG;
-        final boolean isHighlight = options.getType() == StoryViewerOptions.Type.HIGHLIGHT || options.getType() == StoryViewerOptions.Type.STORY_ARCHIVE;
+        final boolean isHighlight = options.getType() == StoryViewerOptions.Type.HIGHLIGHT || options
+                .getType() == StoryViewerOptions.Type.STORY_ARCHIVE;
         userStoryCall.enqueue(new Callback<String>() {
             @Override
             public void onResponse(@NonNull final Call<String> call, @NonNull final Response<String> response) {
@@ -412,7 +412,7 @@ public void onResponse(@NonNull final Call<String> call, @NonNull final Response
                         callback.onSuccess(null);
                     }
                 } catch (JSONException e) {
-                    Log.e(TAG, "Error parsing string");
+                    Log.e(TAG, "Error parsing string", e);
                 }
             }
 

app/src/main/java/awais/instagrabber/workers/DownloadWorker.java

@@ -57,9 +57,6 @@
 import static awais.instagrabber.utils.Constants.DOWNLOAD_CHANNEL_ID;
 import static awais.instagrabber.utils.Constants.NOTIF_GROUP_NAME;
 
-//import awaisomereport.LogCollector;
-//import static awais.instagrabber.utils.Utils.logCollector;
-
 public class DownloadWorker extends Worker {
     private static final String TAG = "DownloadWorker";
     private static final String DOWNLOAD_GROUP = "DOWNLOAD_GROUP";
@@ -340,13 +337,22 @@ private Bitmap getThumbnail(final Context context,
             return bitmap;
         }
         if (mimeType.startsWith("video")) {
-            try (MediaMetadataRetriever retriever = new MediaMetadataRetriever()) {
+            try {
+                MediaMetadataRetriever retriever = new MediaMetadataRetriever();
                 try {
-                    retriever.setDataSource(context, uri);
-                } catch (final Exception e) {
-                    retriever.setDataSource(file.getAbsolutePath());
+                    try {
+                        retriever.setDataSource(context, uri);
+                    } catch (final Exception e) {
+                        retriever.setDataSource(file.getAbsolutePath());
+                    }
+                    bitmap = retriever.getFrameAtTime();
+                } finally {
+                    try {
+                        retriever.release();
+                    } catch (Exception e) {
+                        Log.e(TAG, "getThumbnail: ", e);
+                    }
                 }
-                bitmap = retriever.getFrameAtTime();
             } catch (final Exception e) {
                 Log.e(TAG, "", e);
             }