Squashed 'golang.org/x/tools/' changes from ead62e94e..776604a9e

776604a9e gopls/internal/analysis/modernize: sortslice: fix crash
df7baa073 gopls/internal/analysis/simplifyrange: more precise fix
ad5dd9875 gopls: fix a few bugs related to the new modcache imports source
4b3fdfd83 go/analysis/passes/printf: suppress diagnostic for Println("...%XX...")
fe883a85d gopls/internal/analysis/unusedvariable: refine bug.Report golang/go#71812
d115b345e gopls/internal/analysis: simplify type-error analyzers with Cursor
c18bffa1b all: delete redundant //go:debug gotypesalias=1 directives [generated]
94db71079 all: upgrade go directive to at least 1.23.0 [generated]

git-subtree-dir: golang.org/x/tools
git-subtree-split: 776604a9ed881ee1274724fb3a5f058f3ebdf0eb

Author: github-actions[bot]

cmd/bundle/gotypesalias.go

@@ -5,7 +5,6 @@
 // No testdata on Android.
 
 //go:build !android && go1.11
-// +build !android,go1.11
 
 package main
 

cmd/callgraph/gotypesalias.go

@@ -5,7 +5,6 @@
 // No testdata on Android.
 
 //go:build !android
-// +build !android
 
 package main
 

cmd/callgraph/main_test.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !go1.9
-// +build !go1.9
 
 package main
 

cmd/deadcode/gotypesalias.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build go1.9
-// +build go1.9
 
 package main
 

cmd/eg/gotypesalias.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build gc
-// +build gc
 
 package main
 

cmd/fiximports/main_test.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !gc
-// +build !gc
 
 package main
 

cmd/godex/gotypesalias.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build !go1.9
-// +build !go1.9
 
 // This file contains a copy of the implementation of types.SizesFor
 // since this function is not available in go/types before Go 1.9.

cmd/godex/isAlias18.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build go1.9
-// +build go1.9
 
 package main
 

cmd/godex/isAlias19.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build aix || darwin || dragonfly || freebsd || linux || netbsd || openbsd
-// +build aix darwin dragonfly freebsd linux netbsd openbsd
 
 /*
 Splitdwarf uncompresses and copies the DWARF segment of a Mach-O

cmd/godoc/gotypesalias.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build unix || aix || darwin || dragonfly || freebsd || linux || netbsd || openbsd || solaris || windows
-// +build unix aix darwin dragonfly freebsd linux netbsd openbsd solaris windows
 
 // The stress utility is intended for catching sporadic failures.
 // It runs a given process in parallel in a loop and collects any failures.

cmd/goimports/goimports_gc.go

@@ -1,6 +1,6 @@
 module golang.org/x/tools
 
-go 1.22.0 // => default GODEBUG has gotypesalias=0
+go 1.23.0
 
 require (
 	github.com/google/go-cmp v0.6.0

cmd/goimports/goimports_not_gc.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build go1.12
-// +build go1.12
 
 package multichecker_test
 

cmd/goimports/gotypesalias.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build go1.13
-// +build go1.13
 
 package errorsas_test
 

cmd/gomvpkg/gotypesalias.go

@@ -924,9 +924,14 @@ func checkPrint(pass *analysis.Pass, call *ast.CallExpr, name string) {
 		// The % in "abc 0.0%" couldn't be a formatting directive.
 		s = strings.TrimSuffix(s, "%")
 		if strings.Contains(s, "%") {
-			m := printFormatRE.FindStringSubmatch(s)
-			if m != nil {
-				pass.ReportRangef(call, "%s call has possible Printf formatting directive %s", name, m[0])
+			for _, m := range printFormatRE.FindAllString(s, -1) {
+				// Allow %XX where XX are hex digits,
+				// as this is common in URLs.
+				if len(m) >= 3 && isHex(m[1]) && isHex(m[2]) {
+					continue
+				}
+				pass.ReportRangef(call, "%s call has possible Printf formatting directive %s", name, m)
+				break // report only the first one
 			}
 		}
 	}
@@ -992,3 +997,10 @@ func (ss stringSet) Set(flag string) error {
 //
 // Remove this after the 1.24 release.
 var suppressNonconstants bool
+
+// isHex reports whether b is a hex digit.
+func isHex(b byte) bool {
+	return '0' <= b && b <= '9' ||
+		'A' <= b && b <= 'F' ||
+		'a' <= b && b <= 'f'
+}

cmd/gotype/gotypesalias.go

@@ -154,6 +154,8 @@ func PrintfTests() {
 	fmt.Println("%v", "hi")                     // want "fmt.Println call has possible Printf formatting directive %v"
 	fmt.Println("%T", "hi")                     // want "fmt.Println call has possible Printf formatting directive %T"
 	fmt.Println("%s"+" there", "hi")            // want "fmt.Println call has possible Printf formatting directive %s"
+	fmt.Println("http://foo.com?q%2Fabc")       // no diagnostic: %XX is excepted
+	fmt.Println("http://foo.com?q%2Fabc-%s")    // want"fmt.Println call has possible Printf formatting directive %s"
 	fmt.Println("0.0%")                         // correct (trailing % couldn't be a formatting directive)
 	fmt.Printf("%s", "hi", 3)                   // want "fmt.Printf call needs 1 arg but has 2 args"
 	_ = fmt.Sprintf("%"+("s"), "hi", 3)         // want "fmt.Sprintf call needs 1 arg but has 2 args"

cmd/gotype/sizesFor18.go

@@ -3,7 +3,6 @@
 // license that can be found in the LICENSE file.
 
 //go:build ignore
-// +build ignore
 
 package main