Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement XHTML-specific isValidAttr #4

Open
sbekrin opened this issue Jul 2, 2018 · 0 comments
Open

Implement XHTML-specific isValidAttr #4

sbekrin opened this issue Jul 2, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sbekrin
Copy link
Owner

sbekrin commented Jul 2, 2018 •
edited
Loading

Currently we're using isValidAttr from styled-components which prevents non-valid attributes on DOM nodes. Since XHTML supports less/different attributes, styled-email-components would benefit from a custom xhtml attribute list to avoid "invalid prop" errors and reduce unwanted props destructuring.
@sbekrin sbekrin added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 2, 2018
@sbekrin sbekrin changed the title Use XHTML elements whitelist for isValidAttr Implement XHTML-specific isValidAttr Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbekrin