Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//replacemix param 2 support #109

Open
VorTechnix opened this issue Feb 12, 2024 · 1 comment
Open

//replacemix param 2 support #109

VorTechnix opened this issue Feb 12, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@VorTechnix
Copy link
Collaborator

VorTechnix commented Feb 12, 2024

Problem

Using //replacemix on stairs and such is annoying as param2 is not preserved

Solution

Add a flag to the //replacemix command to preserve param2. E.g. //replacemix [p2] <node_to_replace> <replace_node> ...

Alternatives

A param2 sensitive replacemix command could be implemented alongside the original however this would mean a whole new file of mostly duplicated code and a new command name to memorize.

A mod setting could also be implemented to toggle extended param2 awareness. This would be easier to implement however @sbrl would probably want it as a per-world setting.

@VorTechnix VorTechnix added enhancement New feature or request good first issue Good for newcomers labels Feb 12, 2024
@sbrl
Copy link
Owner

sbrl commented Feb 12, 2024

Hmmm, //replacemix doesn't set param2, so it should be preserved already. That's weird!

@sbrl sbrl added the bug Something isn't working label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants