Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//replacemix shelf bug #70

Open
VorTechnix opened this issue Oct 8, 2021 · 7 comments
Open

//replacemix shelf bug #70

VorTechnix opened this issue Oct 8, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@VorTechnix
Copy link
Collaborator

Bug applies to default:bookshelf, xdecor:multishelf and vessels:shelf. When placed using //replacemix their inventories cannot be opened/accessed.

@VorTechnix VorTechnix added the bug Something isn't working label Oct 8, 2021
@VorTechnix
Copy link
Collaborator Author

Upon further investigation this is an upstream issue as well as the WorldEdit command //set (and i assume the rest of the placing commands) have the same problem. When we find a solution for this issue we should open an issue/pull request in the WorldEdit repo to apply our solution to the commands there.

@VorTechnix
Copy link
Collaborator Author

Chests seem to have the same problem. (But I can't be sure since I have pipeworks which overrides chests).

@sbrl
Copy link
Owner

sbrl commented Oct 8, 2021

Hmmm, weird. Is this also the case if such items are placed on the ground?

It may also be there's an on_place (or whatever it's called) that needs to be called that isn't when we use Voxel Manipulators.

@VorTechnix
Copy link
Collaborator Author

I tried both in air and on the ground. Like you I have a suspicion that there is some sort of on_place weirdness going on. If that is the cause it would not be practical to add node filtering and alternate handling to all our commands. So I propose we make something like //fixstor(age) to handle the issue.

Note: I checked the code yesterday and items like chests and shelves are registered using a function called register_storage not register_node.

@sbrl
Copy link
Owner

sbrl commented Oct 10, 2021

Hmm yeah. It's probably more general than just storage though - something like //setplayer perhaps that uses minetest.set_node()?

@VorTechnix
Copy link
Collaborator Author

Perhaps this is an ownership issue (which would make this issue overlap with #69). It could be that when storage is placed owner is set but only shown/enforced if protected=true.

@sbrl
Copy link
Owner

sbrl commented Oct 10, 2021

Only way to know for sure is to experiment I guess!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants