Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you prefix 'extra-options'? #8

Open
sebastiaansamyn-tc opened this issue Feb 27, 2015 · 2 comments
Open

Could you prefix 'extra-options'? #8

sebastiaansamyn-tc opened this issue Feb 27, 2015 · 2 comments

Comments

@sebastiaansamyn-tc
Copy link

When adding SbtMultiJvm.multiJvmSettings to the settings of my project I get the following error:

[error] Some keys were defined with the same name but different types: 'extra-options' (sbt.Task[scala.collection.Seq[java.lang.String]], scala.Function1[java.lang.String, scala.collection.Seq[java.lang.String]])
[error] Use 'last' for the full log.

The issue is that the extra-options key is not only defined by sbt-multi-jvm, but also by another project. The other project is also not under my own control, so I have no way of using your plugin.

Wouldn't it be a good idea to prefix your keys and not use something as generic as "extra-options"?

@ktoso
Copy link
Member

ktoso commented Mar 2, 2015

Thanks for reporting, I'll have a look at this!
You're most likely right - we should be using (key in ...) I think. I'll investigate more once the sun rises :-)

@ktoso ktoso added this to the 0.3.10 milestone Mar 2, 2015
@ktoso ktoso added the bug label Mar 2, 2015
@2m 2m removed this from the 0.3.10 milestone Aug 12, 2017
@2m
Copy link
Member

2m commented Oct 31, 2017

We should increase the scope of this ticket to go through all of the keys and make sure they have multiJvm prefix or remove keys altogether if they duplicate the meaning of the keys that are already in sbt. More info #39 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants