Skip to content

Commit 1f73ae6

Browse files
authored
Revert "Forbid using window properties as global variables" (facebook#2099)
* Revert "Ignore the yarn cache directory (facebook#2063)" This reverts commit 94149c7. * Revert "Forbid using window properties as global variables (facebook#1840)" This reverts commit 5a7d8e8.
1 parent 035fae1 commit 1f73ae6

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

fixtures/kitchensink/src/App.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class BuiltEmitter extends Component {
2626
}
2727

2828
handleReady() {
29-
document.dispatchEvent(new window.Event('ReactFeatureDidMount'));
29+
document.dispatchEvent(new Event('ReactFeatureDidMount'));
3030
}
3131

3232
render() {
@@ -54,7 +54,7 @@ class App extends Component {
5454
}
5555

5656
componentDidMount() {
57-
const feature = window.location.hash.slice(1);
57+
const feature = location.hash.slice(1);
5858
switch (feature) {
5959
case 'array-destructuring':
6060
import(

fixtures/kitchensink/src/features/webpack/NoExtInclusion.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import React from 'react';
1111
import aFileWithoutExt from './assets/aFileWithoutExt';
1212

1313
const text = aFileWithoutExt.includes('base64')
14-
? window.atob(aFileWithoutExt.split('base64,')[1]).trim()
14+
? atob(aFileWithoutExt.split('base64,')[1]).trim()
1515
: aFileWithoutExt;
1616

1717
export default () => (

fixtures/kitchensink/src/features/webpack/UnknownExtInclusion.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import React from 'react';
1111
import aFileWithExtUnknown from './assets/aFileWithExt.unknown';
1212

1313
const text = aFileWithExtUnknown.includes('base64')
14-
? window.atob(aFileWithExtUnknown.split('base64,')[1]).trim()
14+
? atob(aFileWithExtUnknown.split('base64,')[1]).trim()
1515
: aFileWithExtUnknown;
1616

1717
export default () => (

0 commit comments

Comments
 (0)