Merge pull request #125 from gzm0/quit-not-close

Fix #124: Call quit not close on WebDriver for cleanup

Author: sjrd

seleniumJSEnv/src/main/scala/org/scalajs/jsenv/selenium/SeleniumRun.scala

@@ -162,7 +162,7 @@ private[selenium] object SeleniumRun {
   }
 
   private def maybeCleanupDriver(d: WebDriver, config: SeleniumJSEnv.Config) =
-    if (!config.keepAlive) d.close()
+    if (!config.keepAlive) d.quit()
 
   private def htmlPage(fullInput: Seq[Input], materializer: FileMaterializer): String = {
     val tags = fullInput.map {

seleniumJSEnv/src/test/scala/org/scalajs/jsenv/selenium/KeepAliveTest.scala

@@ -18,7 +18,6 @@ class KeepAliveTest {
   private final class MockWebDriver extends WebDriver with JavascriptExecutor {
     var closed = false
 
-    def close(): Unit = closed = true
     def quit(): Unit = closed = true
 
     def executeScript(code: String, args: Object*): Object =
@@ -36,6 +35,8 @@ class KeepAliveTest {
 
     // Stuff we won't need.
 
+    def close(): Unit = ???
+
     def executeAsyncScript(code: String, args: Object*): Object = ???
 
     def findElement(x1: By): WebElement = ???