Skip to content

Release 1.0.0 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djspiewak opened this issue Sep 7, 2021 · 10 comments
Closed

Release 1.0.0 #21

djspiewak opened this issue Sep 7, 2021 · 10 comments

Comments

@djspiewak
Copy link
Collaborator

This is a very stable library with very small surface area, so I think we're basically going to be fine aggressively moving towards a psychologically "safe" number. It's been tested extensively in Cats Effect, so I don't think we should have any concerns about instability in the implementation.

Cats Effect will want a 1.0.0 release before we're comfortable doing 3.3.0, which will probably happen within about 1-2 months, so I would like it if we could live within that kind of time frame.

IMO we should release an 0.2.0 once @armanbilge runs out of ideas of things to change. ;-) Then let that bake for as long as we feel like, then do a 1.0.0. Process-wise, it'd be great to get @sjrd's blessing on this before we cut 1.0.0.

@armanbilge
Copy link
Member

armanbilge commented Sep 7, 2021

Now I feel like a dry well but I think we're pretty 👍 on 0.2.0 with the JSDOM fix. I already played with some optimizations in typelevel/cats-effect#2231 but those came up dry as well.

Between now and 1.0 it would be awesome to beef up the testing #18 to prove definitely this works anywhere we might care about, but I think we'd be shocked if this uncovers any issues. It's worth noting this code has not only been tested in CE, but it's a fairly faithful port of JS code with 12 million weekly downloads.

@sjrd
Copy link
Member

sjrd commented Sep 7, 2021

Process-wise, it'd be great to get @sjrd's blessing on this before we cut 1.0.0.

It looks fine from my side 👍

@djspiewak
Copy link
Collaborator Author

I'm going to release 0.2.0 on top of current main. We can let that bake for some period of time before pushing out 1.0.0. Note that Cats Effect 3.3.0 will be coming some time within the next six weeks or so (low confidence estimate), and it will want a full release, so that probably puts a cap on the baking time.

@gzm0
Copy link

gzm0 commented Sep 28, 2021

Cross posting from scala-js/scala-js#4556: Should we block Scala.js 1.7.1 on this?

@gzm0
Copy link

gzm0 commented Oct 3, 2021

@djspiewak ping? The Scala.js 1.7.1 release is currently waiting on your input regarding this.

@armanbilge
Copy link
Member

Word in Typelevel is that Daniel is extremely busy at the moment. IMO macrotask is plenty baked for v1.0.0, we haven't made any meaningful changes since 0.2.0: v0.2.0...main

So I suggest you tag macrotask v1.0.0 yourself and CI will release, or if you wish add me to the repo and I can cut the release (I'm also a maintainer for Cats Effect). Otherwise, better not block Scala.js 1.7.1 on this.

@sjrd
Copy link
Member

sjrd commented Oct 4, 2021

I would prefer not to short-circuit Daniel. So I think we'll release Scala.js 1.7.1 as is. The warning can come later anyway.

@djspiewak
Copy link
Collaborator Author

Really terribly sorry for being so out of the loop! I can confirm I've been completely swamped beyond normal swamping. Dipping my head above water very quickly for two thoughts…

  • Let's cut v1.0.0. I think we're good on it and given the level of testing both directly and indirectly, I think we can have a high confidence at least in the API and more likely also in the functionality.
  • I think it's fine if 1.7.1 goes without the warning, though it'd be nice to sneak it in. There will be a 1.7.2, presumably!

A lot of my urgent fires are starting to die down so I can probably take care of point 1 today.

@djspiewak
Copy link
Collaborator Author

Done! https://github.com/scala-js/scala-js-macrotask-executor/releases/tag/v1.0.0

@armanbilge
Copy link
Member

armanbilge commented Oct 10, 2021

Did it? I think the job may have failed: https://github.com/scala-js/scala-js-macrotask-executor/runs/3852973325

On central 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants