Skip to content

Commit 8c680ba

Browse files
authored
Merge pull request #285 from ashawley/rewriterule-name-collision
Remove field RewriteRule.name
2 parents c2db1df + f9786bf commit 8c680ba

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

Diff for: build.sbt

+7
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,13 @@ lazy val xml = crossProject(JSPlatform, JVMPlatform)
2121
scalacOptions ++= "-deprecation:false -feature -Xlint:-stars-align,-nullary-unit,_".split("\\s+").to[Seq],
2222
scalacOptions in Test += "-Xxml:coalescing",
2323

24+
mimaBinaryIssueFilters ++= {
25+
import com.typesafe.tools.mima.core._
26+
import com.typesafe.tools.mima.core.ProblemFilters._
27+
Seq(
28+
exclude[DirectMissingMethodProblem]("scala.xml.transform.RewriteRule.name")
29+
)
30+
},
2431
mimaPreviousVersion := {
2532
if (System.getenv("SCALAJS_VERSION") == "1.0.0-M6") None // No such release yet
2633
else Some("1.1.1")

Diff for: shared/src/main/scala/scala/xml/transform/RewriteRule.scala

-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ import scala.collection.Seq
2020
* @author Burak Emir
2121
*/
2222
abstract class RewriteRule extends BasicTransformer {
23-
/** a name for this rewrite rule */
24-
val name = this.toString()
2523
override def transform(ns: Seq[Node]): Seq[Node] = super.transform(ns)
2624
override def transform(n: Node): Seq[Node] = n
2725
}

0 commit comments

Comments
 (0)