Use FactoryAdapter as ContentHandler crashes

[lrytz]

This used to work a while ago

  @UnitTest
  def contentHandler(): Unit = {
    val p = defaultParserFactory.newSAXParser()
    val handler = new parsing.NoBindingFactoryAdapter
    val input = new ByteArrayInputStream("<hello>world</hello>".getBytes("UTF-8"))
    p.parse(input, handler)
    val n: Node = handler.rootElem
  }

This bypasses FactoryAdapter.loadDocument, which is used internally within scala.xml.

Currently:

• After XMLLoader returns Document #663, rootElem is set to null
• After Capture more of the Document #668, endDocument crashes with None.get in xmlReader.get.getProperty(...)

I came across some code at a customer that uses NoBindingFactoryAdapter as a ContentHandler in their internal XML library to convert to scala.xml.

I can work around it by overriding def endDocument(), getting out the rootElem and avoid calling super.endDocument().

I don't know if the use case should be supported?

[dubinsky]

I don't know if the use case should be supported?

I do not think it should be. In fact, I do not think that Scala XML should expose any "content handlers" or "factory adapters" at all - methods like XML.load(InputStteam) seem sufficient...