From 562ea8329881112f24aa5ec69953f49b237773dc Mon Sep 17 00:00:00 2001 From: Lukas Rytz Date: Thu, 22 Mar 2018 21:58:40 +0100 Subject: [PATCH 1/4] Seq => collection.Seq Preserve for binary compatability. Scala 2.13 collections rewrite defaults to immutable.Seq. --- jvm/src/test/scala/scala/xml/ReuseNodesTest.scala | 1 + jvm/src/test/scala/scala/xml/SerializationTest.scala | 1 + jvm/src/test/scala/scala/xml/XMLTest.scala | 1 + shared/src/main/scala/scala/xml/Atom.scala | 2 ++ shared/src/main/scala/scala/xml/Attribute.scala | 2 ++ shared/src/main/scala/scala/xml/Document.scala | 2 ++ shared/src/main/scala/scala/xml/Elem.scala | 2 ++ shared/src/main/scala/scala/xml/Equality.scala | 2 ++ shared/src/main/scala/scala/xml/Group.scala | 2 ++ shared/src/main/scala/scala/xml/MetaData.scala | 1 + shared/src/main/scala/scala/xml/NamespaceBinding.scala | 1 + shared/src/main/scala/scala/xml/Node.scala | 2 ++ shared/src/main/scala/scala/xml/NodeSeq.scala | 1 + shared/src/main/scala/scala/xml/Null.scala | 1 + shared/src/main/scala/scala/xml/PrefixedAttribute.scala | 2 ++ shared/src/main/scala/scala/xml/PrettyPrinter.scala | 1 + shared/src/main/scala/scala/xml/TextBuffer.scala | 1 + shared/src/main/scala/scala/xml/UnprefixedAttribute.scala | 2 ++ shared/src/main/scala/scala/xml/Utility.scala | 1 + shared/src/main/scala/scala/xml/Xhtml.scala | 1 + shared/src/main/scala/scala/xml/dtd/ContentModel.scala | 1 + shared/src/main/scala/scala/xml/dtd/DTD.scala | 1 + shared/src/main/scala/scala/xml/dtd/DocType.scala | 2 ++ shared/src/main/scala/scala/xml/dtd/ElementValidator.scala | 1 + shared/src/main/scala/scala/xml/dtd/Scanner.scala | 2 ++ shared/src/main/scala/scala/xml/dtd/impl/BaseBerrySethi.scala | 1 + shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala | 2 ++ shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala | 1 + shared/src/main/scala/scala/xml/dtd/impl/WordBerrySethi.scala | 1 + shared/src/main/scala/scala/xml/factory/LoggedNodeFactory.scala | 2 ++ shared/src/main/scala/scala/xml/factory/NodeFactory.scala | 2 ++ shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala | 1 + .../src/main/scala/scala/xml/parsing/MarkupParserCommon.scala | 1 + .../main/scala/scala/xml/parsing/NoBindingFactoryAdapter.scala | 1 + shared/src/main/scala/scala/xml/parsing/TokenTests.scala | 2 ++ .../src/main/scala/scala/xml/transform/BasicTransformer.scala | 2 ++ shared/src/main/scala/scala/xml/transform/RewriteRule.scala | 2 ++ shared/src/main/scala/scala/xml/transform/RuleTransformer.scala | 2 ++ shared/src/test/scala/scala/xml/AttributeTest.scala | 1 + shared/src/test/scala/scala/xml/PatternMatching.scala | 1 + shared/src/test/scala/scala/xml/Transformers.scala | 1 + shared/src/test/scala/scala/xml/UtilityTest.scala | 1 + shared/src/test/scala/scala/xml/XMLSyntaxTest.scala | 1 + shared/src/test/scala/scala/xml/XMLTest.scala | 1 + 44 files changed, 62 insertions(+) diff --git a/jvm/src/test/scala/scala/xml/ReuseNodesTest.scala b/jvm/src/test/scala/scala/xml/ReuseNodesTest.scala index 586fb92a0..f419a1de4 100644 --- a/jvm/src/test/scala/scala/xml/ReuseNodesTest.scala +++ b/jvm/src/test/scala/scala/xml/ReuseNodesTest.scala @@ -1,6 +1,7 @@ package scala.xml import scala.xml.transform._ +import scala.collection.Seq import org.junit.Assert.assertSame import org.junit.experimental.theories.Theories import org.junit.experimental.theories.Theory diff --git a/jvm/src/test/scala/scala/xml/SerializationTest.scala b/jvm/src/test/scala/scala/xml/SerializationTest.scala index d3f4eb754..37da4c296 100644 --- a/jvm/src/test/scala/scala/xml/SerializationTest.scala +++ b/jvm/src/test/scala/scala/xml/SerializationTest.scala @@ -1,5 +1,6 @@ package scala.xml +import scala.collection.Seq import org.junit.Assert.assertEquals import org.junit.Test diff --git a/jvm/src/test/scala/scala/xml/XMLTest.scala b/jvm/src/test/scala/scala/xml/XMLTest.scala index dfd06aef1..64813c732 100644 --- a/jvm/src/test/scala/scala/xml/XMLTest.scala +++ b/jvm/src/test/scala/scala/xml/XMLTest.scala @@ -11,6 +11,7 @@ import java.io.StringWriter import java.io.ByteArrayOutputStream import java.io.StringReader import scala.collection.Iterable +import scala.collection.Seq import scala.xml.Utility.sort object XMLTestJVM { diff --git a/shared/src/main/scala/scala/xml/Atom.scala b/shared/src/main/scala/scala/xml/Atom.scala index b8ee13397..311157147 100644 --- a/shared/src/main/scala/scala/xml/Atom.scala +++ b/shared/src/main/scala/scala/xml/Atom.scala @@ -9,6 +9,8 @@ package scala package xml +import scala.collection.Seq + /** * The class `Atom` provides an XML node for text (`PCDATA`). * It is used in both non-bound and bound XML representations. diff --git a/shared/src/main/scala/scala/xml/Attribute.scala b/shared/src/main/scala/scala/xml/Attribute.scala index d8ca107fb..4423ad9ab 100644 --- a/shared/src/main/scala/scala/xml/Attribute.scala +++ b/shared/src/main/scala/scala/xml/Attribute.scala @@ -9,6 +9,8 @@ package scala package xml +import scala.collection.Seq + /** * This singleton object contains the `apply` and `unapply` methods for * convenient construction and deconstruction. diff --git a/shared/src/main/scala/scala/xml/Document.scala b/shared/src/main/scala/scala/xml/Document.scala index 672f0284d..6213e0e40 100644 --- a/shared/src/main/scala/scala/xml/Document.scala +++ b/shared/src/main/scala/scala/xml/Document.scala @@ -9,6 +9,8 @@ package scala package xml +import scala.collection.Seq + /** * A document information item (according to InfoSet spec). The comments * are copied from the Infoset spec, only augmented with some information diff --git a/shared/src/main/scala/scala/xml/Elem.scala b/shared/src/main/scala/scala/xml/Elem.scala index 4c308017e..8392255ca 100755 --- a/shared/src/main/scala/scala/xml/Elem.scala +++ b/shared/src/main/scala/scala/xml/Elem.scala @@ -11,6 +11,8 @@ package scala package xml +import scala.collection.Seq + /** * This singleton object contains the `apply` and `unapplySeq` methods for * convenient construction and deconstruction. It is possible to deconstruct diff --git a/shared/src/main/scala/scala/xml/Equality.scala b/shared/src/main/scala/scala/xml/Equality.scala index 44d6a8d4b..9f22fc2fb 100644 --- a/shared/src/main/scala/scala/xml/Equality.scala +++ b/shared/src/main/scala/scala/xml/Equality.scala @@ -9,6 +9,8 @@ package scala package xml +import scala.collection.Seq + /** * In an attempt to contain the damage being inflicted on consistency by the * ad hoc `equals` methods spread around `xml`, the logic is centralized and diff --git a/shared/src/main/scala/scala/xml/Group.scala b/shared/src/main/scala/scala/xml/Group.scala index a539530d8..dc4c19960 100644 --- a/shared/src/main/scala/scala/xml/Group.scala +++ b/shared/src/main/scala/scala/xml/Group.scala @@ -9,6 +9,8 @@ package scala package xml +import scala.collection.Seq + /** * A hack to group XML nodes in one node for output. * diff --git a/shared/src/main/scala/scala/xml/MetaData.scala b/shared/src/main/scala/scala/xml/MetaData.scala index 48e7173d9..1affff4e0 100644 --- a/shared/src/main/scala/scala/xml/MetaData.scala +++ b/shared/src/main/scala/scala/xml/MetaData.scala @@ -14,6 +14,7 @@ package xml import Utility.sbToString import scala.annotation.tailrec import scala.collection.AbstractIterable +import scala.collection.Seq object MetaData { /** diff --git a/shared/src/main/scala/scala/xml/NamespaceBinding.scala b/shared/src/main/scala/scala/xml/NamespaceBinding.scala index 7bc2ca43d..e8ad08f77 100644 --- a/shared/src/main/scala/scala/xml/NamespaceBinding.scala +++ b/shared/src/main/scala/scala/xml/NamespaceBinding.scala @@ -9,6 +9,7 @@ package scala package xml +import scala.collection.Seq import Utility.sbToString /** diff --git a/shared/src/main/scala/scala/xml/Node.scala b/shared/src/main/scala/scala/xml/Node.scala index 57ed966e3..f62edabda 100755 --- a/shared/src/main/scala/scala/xml/Node.scala +++ b/shared/src/main/scala/scala/xml/Node.scala @@ -9,6 +9,8 @@ package scala package xml +import scala.collection.Seq + /** * This singleton object contains the `unapplySeq` method for * convenient deconstruction. diff --git a/shared/src/main/scala/scala/xml/NodeSeq.scala b/shared/src/main/scala/scala/xml/NodeSeq.scala index bc88aca19..f93c6249e 100644 --- a/shared/src/main/scala/scala/xml/NodeSeq.scala +++ b/shared/src/main/scala/scala/xml/NodeSeq.scala @@ -13,6 +13,7 @@ import scala.collection.{ mutable, immutable, generic, SeqLike, AbstractSeq } import mutable.{ Builder, ListBuffer } import generic.{ CanBuildFrom } import scala.language.implicitConversions +import scala.collection.Seq /** * This object ... diff --git a/shared/src/main/scala/scala/xml/Null.scala b/shared/src/main/scala/scala/xml/Null.scala index 9d6a5c9af..6e438a53b 100644 --- a/shared/src/main/scala/scala/xml/Null.scala +++ b/shared/src/main/scala/scala/xml/Null.scala @@ -11,6 +11,7 @@ package xml import Utility.isNameStart import scala.collection.Iterator +import scala.collection.Seq /** * Essentially, every method in here is a dummy, returning Zero[T]. diff --git a/shared/src/main/scala/scala/xml/PrefixedAttribute.scala b/shared/src/main/scala/scala/xml/PrefixedAttribute.scala index f269ba748..b1408d287 100644 --- a/shared/src/main/scala/scala/xml/PrefixedAttribute.scala +++ b/shared/src/main/scala/scala/xml/PrefixedAttribute.scala @@ -9,6 +9,8 @@ package scala package xml +import scala.collection.Seq + /** * prefixed attributes always have a non-null namespace. * diff --git a/shared/src/main/scala/scala/xml/PrettyPrinter.scala b/shared/src/main/scala/scala/xml/PrettyPrinter.scala index 6cb3f6cdb..b5f41d157 100755 --- a/shared/src/main/scala/scala/xml/PrettyPrinter.scala +++ b/shared/src/main/scala/scala/xml/PrettyPrinter.scala @@ -9,6 +9,7 @@ package scala package xml +import scala.collection.Seq import Utility.sbToString /** diff --git a/shared/src/main/scala/scala/xml/TextBuffer.scala b/shared/src/main/scala/scala/xml/TextBuffer.scala index 0206b2e3e..8ab2a53e4 100644 --- a/shared/src/main/scala/scala/xml/TextBuffer.scala +++ b/shared/src/main/scala/scala/xml/TextBuffer.scala @@ -9,6 +9,7 @@ package scala package xml +import scala.collection.Seq import Utility.isSpace object TextBuffer { diff --git a/shared/src/main/scala/scala/xml/UnprefixedAttribute.scala b/shared/src/main/scala/scala/xml/UnprefixedAttribute.scala index db89b8913..d7ead87dc 100644 --- a/shared/src/main/scala/scala/xml/UnprefixedAttribute.scala +++ b/shared/src/main/scala/scala/xml/UnprefixedAttribute.scala @@ -9,6 +9,8 @@ package scala package xml +import scala.collection.Seq + /** * Unprefixed attributes have the null namespace, and no prefix field * diff --git a/shared/src/main/scala/scala/xml/Utility.scala b/shared/src/main/scala/scala/xml/Utility.scala index ce14fbc85..b40adf2d8 100755 --- a/shared/src/main/scala/scala/xml/Utility.scala +++ b/shared/src/main/scala/scala/xml/Utility.scala @@ -11,6 +11,7 @@ package xml import scala.collection.mutable import scala.language.implicitConversions +import scala.collection.Seq /** * The `Utility` object provides utility functions for processing instances diff --git a/shared/src/main/scala/scala/xml/Xhtml.scala b/shared/src/main/scala/scala/xml/Xhtml.scala index ad5fbeda0..5d89101e0 100644 --- a/shared/src/main/scala/scala/xml/Xhtml.scala +++ b/shared/src/main/scala/scala/xml/Xhtml.scala @@ -4,6 +4,7 @@ package xml import parsing.XhtmlEntities import Utility.{ sbToString, isAtomAndNotText } +import scala.collection.Seq /* (c) David Pollak 2007 WorldWide Conferencing, LLC */ diff --git a/shared/src/main/scala/scala/xml/dtd/ContentModel.scala b/shared/src/main/scala/scala/xml/dtd/ContentModel.scala index 32d07c6c1..a36674d61 100644 --- a/shared/src/main/scala/scala/xml/dtd/ContentModel.scala +++ b/shared/src/main/scala/scala/xml/dtd/ContentModel.scala @@ -10,6 +10,7 @@ package scala package xml package dtd +import scala.collection.Seq import scala.xml.dtd.impl._ import scala.xml.Utility.sbToString import PartialFunction._ diff --git a/shared/src/main/scala/scala/xml/dtd/DTD.scala b/shared/src/main/scala/scala/xml/dtd/DTD.scala index 51ab31226..f01fe5a0a 100644 --- a/shared/src/main/scala/scala/xml/dtd/DTD.scala +++ b/shared/src/main/scala/scala/xml/dtd/DTD.scala @@ -11,6 +11,7 @@ package xml package dtd import scala.collection.mutable +import scala.collection.Seq /** * A document type declaration. diff --git a/shared/src/main/scala/scala/xml/dtd/DocType.scala b/shared/src/main/scala/scala/xml/dtd/DocType.scala index f78403440..4bc78b1a2 100644 --- a/shared/src/main/scala/scala/xml/dtd/DocType.scala +++ b/shared/src/main/scala/scala/xml/dtd/DocType.scala @@ -10,6 +10,8 @@ package scala package xml package dtd +import scala.collection.Seq + /** * An XML node for document type declaration. * diff --git a/shared/src/main/scala/scala/xml/dtd/ElementValidator.scala b/shared/src/main/scala/scala/xml/dtd/ElementValidator.scala index 4d5ff979d..c30c2af17 100644 --- a/shared/src/main/scala/scala/xml/dtd/ElementValidator.scala +++ b/shared/src/main/scala/scala/xml/dtd/ElementValidator.scala @@ -12,6 +12,7 @@ package dtd import PartialFunction._ import scala.collection.mutable +import scala.collection.Seq import ContentModel.ElemName import MakeValidationException._ // @todo other exceptions diff --git a/shared/src/main/scala/scala/xml/dtd/Scanner.scala b/shared/src/main/scala/scala/xml/dtd/Scanner.scala index 24160cddc..425f3cd7f 100644 --- a/shared/src/main/scala/scala/xml/dtd/Scanner.scala +++ b/shared/src/main/scala/scala/xml/dtd/Scanner.scala @@ -10,6 +10,8 @@ package scala package xml package dtd +import scala.collection.Seq + /** * Scanner for regexps (content models in DTD element declarations) * todo: cleanup diff --git a/shared/src/main/scala/scala/xml/dtd/impl/BaseBerrySethi.scala b/shared/src/main/scala/scala/xml/dtd/impl/BaseBerrySethi.scala index e7c68e2ed..869ed9ae4 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/BaseBerrySethi.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/BaseBerrySethi.scala @@ -10,6 +10,7 @@ package scala package xml.dtd.impl import scala.collection.{ mutable, immutable } +import scala.collection.Seq // todo: replace global variable pos with acc diff --git a/shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala b/shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala index 0f1e201b0..709c2c530 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/Inclusion.scala @@ -9,6 +9,8 @@ package scala package xml.dtd.impl +import scala.collection.Seq + /** * A fast test of language inclusion between minimal automata. * inspired by the ''AMoRE automata library''. diff --git a/shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala b/shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala index 07beed479..09f1b1d3f 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala @@ -10,6 +10,7 @@ package scala package xml.dtd.impl import scala.collection.{ immutable, mutable } +import scala.collection.Seq /** * A nondeterministic automaton. States are integers, where diff --git a/shared/src/main/scala/scala/xml/dtd/impl/WordBerrySethi.scala b/shared/src/main/scala/scala/xml/dtd/impl/WordBerrySethi.scala index e96cd1299..3f0ef361f 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/WordBerrySethi.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/WordBerrySethi.scala @@ -10,6 +10,7 @@ package scala package xml.dtd.impl import scala.collection.{ immutable, mutable } +import scala.collection.Seq /** * This class turns a regular expression into a [[scala.util.automata.NondetWordAutom]] diff --git a/shared/src/main/scala/scala/xml/factory/LoggedNodeFactory.scala b/shared/src/main/scala/scala/xml/factory/LoggedNodeFactory.scala index e8189eb7f..10bf57f56 100644 --- a/shared/src/main/scala/scala/xml/factory/LoggedNodeFactory.scala +++ b/shared/src/main/scala/scala/xml/factory/LoggedNodeFactory.scala @@ -10,6 +10,8 @@ package scala package xml package factory +import scala.collection.Seq + /** * This class logs what the nodefactory is actually doing. * If you want to see what happens during loading, use it like this: diff --git a/shared/src/main/scala/scala/xml/factory/NodeFactory.scala b/shared/src/main/scala/scala/xml/factory/NodeFactory.scala index 283fd8fd5..2ca162952 100644 --- a/shared/src/main/scala/scala/xml/factory/NodeFactory.scala +++ b/shared/src/main/scala/scala/xml/factory/NodeFactory.scala @@ -10,6 +10,8 @@ package scala package xml package factory +import scala.collection.Seq + trait NodeFactory[A <: Node] { val ignoreComments = false val ignoreProcInstr = false diff --git a/shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala b/shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala index 607a0aace..d181621dd 100644 --- a/shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala +++ b/shared/src/main/scala/scala/xml/parsing/FactoryAdapter.scala @@ -11,6 +11,7 @@ package xml package parsing import scala.collection.{ mutable, Iterator } +import scala.collection.Seq import org.xml.sax.Attributes import org.xml.sax.helpers.DefaultHandler diff --git a/shared/src/main/scala/scala/xml/parsing/MarkupParserCommon.scala b/shared/src/main/scala/scala/xml/parsing/MarkupParserCommon.scala index 2685f0632..a6b2ec187 100644 --- a/shared/src/main/scala/scala/xml/parsing/MarkupParserCommon.scala +++ b/shared/src/main/scala/scala/xml/parsing/MarkupParserCommon.scala @@ -10,6 +10,7 @@ package scala package xml package parsing +import scala.collection.Seq import Utility.SU /** diff --git a/shared/src/main/scala/scala/xml/parsing/NoBindingFactoryAdapter.scala b/shared/src/main/scala/scala/xml/parsing/NoBindingFactoryAdapter.scala index 92675897d..8b0711aa0 100644 --- a/shared/src/main/scala/scala/xml/parsing/NoBindingFactoryAdapter.scala +++ b/shared/src/main/scala/scala/xml/parsing/NoBindingFactoryAdapter.scala @@ -10,6 +10,7 @@ package scala package xml package parsing +import scala.collection.Seq import factory.NodeFactory /** diff --git a/shared/src/main/scala/scala/xml/parsing/TokenTests.scala b/shared/src/main/scala/scala/xml/parsing/TokenTests.scala index 5e277dcde..3db0ece88 100644 --- a/shared/src/main/scala/scala/xml/parsing/TokenTests.scala +++ b/shared/src/main/scala/scala/xml/parsing/TokenTests.scala @@ -10,6 +10,8 @@ package scala package xml package parsing +import scala.collection.Seq + /** * Helper functions for parsing XML fragments */ diff --git a/shared/src/main/scala/scala/xml/transform/BasicTransformer.scala b/shared/src/main/scala/scala/xml/transform/BasicTransformer.scala index fd0d9560f..7d659d5f4 100644 --- a/shared/src/main/scala/scala/xml/transform/BasicTransformer.scala +++ b/shared/src/main/scala/scala/xml/transform/BasicTransformer.scala @@ -10,6 +10,8 @@ package scala package xml package transform +import scala.collection.Seq + /** * A class for XML transformations. * diff --git a/shared/src/main/scala/scala/xml/transform/RewriteRule.scala b/shared/src/main/scala/scala/xml/transform/RewriteRule.scala index c6b9df923..b9374e7e5 100644 --- a/shared/src/main/scala/scala/xml/transform/RewriteRule.scala +++ b/shared/src/main/scala/scala/xml/transform/RewriteRule.scala @@ -10,6 +10,8 @@ package scala package xml package transform +import scala.collection.Seq + /** * A RewriteRule, when applied to a term, yields either * the result of rewriting the term or the term itself if the rule diff --git a/shared/src/main/scala/scala/xml/transform/RuleTransformer.scala b/shared/src/main/scala/scala/xml/transform/RuleTransformer.scala index c9a57f17d..1b71071cb 100644 --- a/shared/src/main/scala/scala/xml/transform/RuleTransformer.scala +++ b/shared/src/main/scala/scala/xml/transform/RuleTransformer.scala @@ -10,6 +10,8 @@ package scala package xml package transform +import scala.collection.Seq + class RuleTransformer(rules: RewriteRule*) extends BasicTransformer { override def transform(n: Node): Seq[Node] = rules.foldLeft(super.transform(n)) { (res, rule) => rule transform res } diff --git a/shared/src/test/scala/scala/xml/AttributeTest.scala b/shared/src/test/scala/scala/xml/AttributeTest.scala index 8943a0a00..0b3891496 100644 --- a/shared/src/test/scala/scala/xml/AttributeTest.scala +++ b/shared/src/test/scala/scala/xml/AttributeTest.scala @@ -1,5 +1,6 @@ package scala.xml +import scala.collection.Seq import org.junit.Test import org.junit.Assert.assertEquals diff --git a/shared/src/test/scala/scala/xml/PatternMatching.scala b/shared/src/test/scala/scala/xml/PatternMatching.scala index fbf94b62b..41644cec1 100644 --- a/shared/src/test/scala/scala/xml/PatternMatching.scala +++ b/shared/src/test/scala/scala/xml/PatternMatching.scala @@ -1,5 +1,6 @@ package scala.xml +import scala.collection.Seq import org.junit.Test import org.junit.Assert.assertTrue import org.junit.Assert.assertEquals diff --git a/shared/src/test/scala/scala/xml/Transformers.scala b/shared/src/test/scala/scala/xml/Transformers.scala index 5cec41080..146a480a3 100644 --- a/shared/src/test/scala/scala/xml/Transformers.scala +++ b/shared/src/test/scala/scala/xml/Transformers.scala @@ -1,5 +1,6 @@ package scala.xml +import scala.collection.Seq import scala.xml.transform._ import org.junit.Test diff --git a/shared/src/test/scala/scala/xml/UtilityTest.scala b/shared/src/test/scala/scala/xml/UtilityTest.scala index b365294c9..44db70d67 100644 --- a/shared/src/test/scala/scala/xml/UtilityTest.scala +++ b/shared/src/test/scala/scala/xml/UtilityTest.scala @@ -1,5 +1,6 @@ package scala.xml +import scala.collection.Seq import org.junit.Test import org.junit.Assert.assertTrue import org.junit.Assert.assertEquals diff --git a/shared/src/test/scala/scala/xml/XMLSyntaxTest.scala b/shared/src/test/scala/scala/xml/XMLSyntaxTest.scala index 89b9bdbbc..913c027f0 100644 --- a/shared/src/test/scala/scala/xml/XMLSyntaxTest.scala +++ b/shared/src/test/scala/scala/xml/XMLSyntaxTest.scala @@ -1,5 +1,6 @@ package scala.xml +import scala.collection.Seq import org.junit.Test import org.junit.Assert.assertTrue import org.junit.Assert.assertFalse diff --git a/shared/src/test/scala/scala/xml/XMLTest.scala b/shared/src/test/scala/scala/xml/XMLTest.scala index 43366300b..6147f56b4 100644 --- a/shared/src/test/scala/scala/xml/XMLTest.scala +++ b/shared/src/test/scala/scala/xml/XMLTest.scala @@ -9,6 +9,7 @@ import org.junit.Assert.assertEquals // import scala.xml.parsing.ConstructingParser import java.io.StringWriter import scala.collection.Iterable +import scala.collection.Seq import scala.xml.Utility.sort object XMLTest { From 59dd7425752dfdc4dbc5fe56dddaa3c34e368b7a Mon Sep 17 00:00:00 2001 From: "Aaron S. Hawley" Date: Mon, 16 Apr 2018 00:55:28 -0400 Subject: [PATCH 2/4] Convert BitSet.toSet Fix compiler error with Scala 2.13 collections rewrite: ambiguous reference to overloaded definition, both method map in trait StrictOptimizedIterableOps of type [B](f: Int => B)scala.collection.immutable.Set[B] and method map in trait SortedSetOps of type [B](f: Int => B)(implicit evidence$4: Ordering[B])scala.collection.immutable.SortedSet[B] match argument types (Int => scala.collection.immutable.BitSet) (Q map f).foldLeft(immutable.BitSet.empty)(_ ++ _) ^ --- shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala b/shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala index 09f1b1d3f..91fdf86c0 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/NondetWordAutom.scala @@ -48,7 +48,7 @@ private[dtd] abstract class NondetWordAutom[T <: AnyRef] { def nextDefault(Q: immutable.BitSet): immutable.BitSet = next(Q, default) private def next(Q: immutable.BitSet, f: (Int) => immutable.BitSet): immutable.BitSet = - (Q map f).foldLeft(immutable.BitSet.empty)(_ ++ _) + Q.toSet.map(f).foldLeft(immutable.BitSet.empty)(_ ++ _) private def finalStates = 0 until nstates filter isFinal override def toString = { From b1331176d45b9308f661a2a70830cda5927bfda9 Mon Sep 17 00:00:00 2001 From: "Aaron S. Hawley" Date: Mon, 16 Apr 2018 00:57:50 -0400 Subject: [PATCH 3/4] Use immutable.Map and val Compiler complains after Scala 2.13 collections rewrite that value updated is not a member of scala.collection.Map --- .../scala/xml/dtd/impl/SubsetConstruction.scala | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala b/shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala index 6b74839fd..2dddfdcec 100644 --- a/shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala +++ b/shared/src/main/scala/scala/xml/dtd/impl/SubsetConstruction.scala @@ -20,8 +20,8 @@ private[dtd] class SubsetConstruction[T <: AnyRef](val nfa: NondetWordAutom[T]) def determinize: DetWordAutom[T] = { // for assigning numbers to bitsets - var indexMap = scala.collection.Map[immutable.BitSet, Int]() - var invIndexMap = scala.collection.Map[Int, immutable.BitSet]() + val indexMap = mutable.Map[immutable.BitSet, Int]() + val invIndexMap = mutable.Map[Int, immutable.BitSet]() var ix = 0 // we compute the dfa with states = bitsets @@ -30,15 +30,15 @@ private[dtd] class SubsetConstruction[T <: AnyRef](val nfa: NondetWordAutom[T]) var states = Set(q0, sink) // initial set of sets val delta = new mutable.HashMap[immutable.BitSet, mutable.HashMap[T, immutable.BitSet]] - var deftrans = mutable.Map(q0 -> sink, sink -> sink) // initial transitions - var finals: mutable.Map[immutable.BitSet, Int] = mutable.Map() + val deftrans = mutable.Map(q0 -> sink, sink -> sink) // initial transitions + val finals: mutable.Map[immutable.BitSet, Int] = mutable.Map() val rest = new mutable.Stack[immutable.BitSet] rest.push(sink, q0) def addFinal(q: immutable.BitSet): Unit = { if (nfa containsFinal q) - finals = finals.updated(q, selectTag(q, nfa.finals)) + finals(q) = selectTag(q, nfa.finals) } def add(Q: immutable.BitSet): Unit = { if (!states(Q)) { @@ -53,8 +53,8 @@ private[dtd] class SubsetConstruction[T <: AnyRef](val nfa: NondetWordAutom[T]) while (!rest.isEmpty) { val P = rest.pop() // assign a number to this bitset - indexMap = indexMap.updated(P, ix) - invIndexMap = invIndexMap.updated(ix, P) + indexMap(P) = ix + invIndexMap(ix) = P ix += 1 // make transition map @@ -69,7 +69,7 @@ private[dtd] class SubsetConstruction[T <: AnyRef](val nfa: NondetWordAutom[T]) // collect default transitions val Pdef = nfa nextDefault P - deftrans = deftrans.updated(P, Pdef) + deftrans(P) = Pdef add(Pdef) } From 4d1d67ad093a573797f1f832cd64252052a6d1f7 Mon Sep 17 00:00:00 2001 From: "Aaron S. Hawley" Date: Mon, 16 Apr 2018 01:13:35 -0400 Subject: [PATCH 4/4] Use StringBuilder.setLength Compiler complains with new Scala 2.13 collection reassignment to val cbuf.length = 0 ^ --- .../scala/scala/xml/parsing/MarkupParser.scala | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/shared/src/main/scala/scala/xml/parsing/MarkupParser.scala b/shared/src/main/scala/scala/xml/parsing/MarkupParser.scala index 0bea3784e..81d5b82cc 100755 --- a/shared/src/main/scala/scala/xml/parsing/MarkupParser.scala +++ b/shared/src/main/scala/scala/xml/parsing/MarkupParser.scala @@ -358,7 +358,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { } nextch() val str = cbuf.toString() - cbuf.length = 0 + cbuf.setLength(0) str } @@ -390,7 +390,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { xToken("--") while (!eof) { if (ch == '-' && { sb.append(ch); nextch(); ch == '-' }) { - sb.length = sb.length - 1 + sb.setLength(sb.length - 1) nextch() xToken('>') return handle.comment(pos, sb.toString()) @@ -608,7 +608,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { exit = eof || (ch == '<') || (ch == '&') } val str = cbuf.toString - cbuf.length = 0 + cbuf.setLength(0) str } @@ -630,7 +630,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { } nextch() val str = cbuf.toString() - cbuf.length = 0 + cbuf.setLength(0) str } @@ -653,7 +653,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { } nextch() val str = cbuf.toString - cbuf.length = 0 + cbuf.setLength(0) str } @@ -799,7 +799,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { //Console.println("END["+ch+"]") nextch() val cmstr = cbuf.toString() - cbuf.length = 0 + cbuf.setLength(0) handle.elemDecl(n, cmstr) } @@ -826,7 +826,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { nextch() } val atpe = cbuf.toString - cbuf.length = 0 + cbuf.setLength(0) val defdecl: DefaultDecl = ch match { case '\'' | '"' => @@ -846,7 +846,7 @@ trait MarkupParser extends MarkupParserCommon with TokenTests { xSpaceOpt() attList ::= AttrDecl(aname, atpe, defdecl) - cbuf.length = 0 + cbuf.setLength(0) } nextch() handle.attListDecl(n, attList.reverse)