Skip to content

Commit e9e046d

Browse files
authored
Respect [skip-ci] comments in launchers and spec tests (#21472)
Currently, Specification and Launchers CI would execute even when the `skip ci` tag message is part of the PR. The goal of this change is to ignore these jobs when annotated. The only remaining CI job running under skip ci is `Scala CLA check`
2 parents a37da19 + 3bd4a7a commit e9e046d

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

.github/workflows/ci.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -1017,6 +1017,12 @@ jobs:
10171017

10181018
build-sdk-package:
10191019
uses: ./.github/workflows/build-sdk.yml
1020+
if:
1021+
(github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]')) ||
1022+
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3') ||
1023+
(github.event_name == 'schedule' && github.repository == 'scala/scala3') ||
1024+
github.event_name == 'push' ||
1025+
github.event_name == 'merge_group'
10201026
with:
10211027
java-version: 8
10221028

.github/workflows/launchers.yml

+8
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ jobs:
1010
linux-x86_64:
1111
name: Deploy and Test on Linux x64 architecture
1212
runs-on: ubuntu-latest
13+
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
14+
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
1315
steps:
1416
- uses: actions/checkout@v4
1517
- name: Set up JDK 17
@@ -46,6 +48,8 @@ jobs:
4648
mac-x86_64:
4749
name: Deploy and Test on Mac x64 architecture
4850
runs-on: macos-13
51+
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
52+
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
4953
steps:
5054
- uses: actions/checkout@v4
5155
- name: Set up JDK 17
@@ -65,6 +69,8 @@ jobs:
6569
mac-aarch64:
6670
name: Deploy and Test on Mac ARM64 architecture
6771
runs-on: macos-latest
72+
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
73+
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
6874
steps:
6975
- uses: actions/checkout@v4
7076
- name: Set up JDK 17
@@ -84,6 +90,8 @@ jobs:
8490
win-x86_64:
8591
name: Deploy and Test on Windows x64 architecture
8692
runs-on: windows-latest
93+
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]') ) ||
94+
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3' )
8795
steps:
8896
- uses: actions/checkout@v4
8997
- name: Set up JDK 17

.github/workflows/spec.yml

+4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ env:
1616
jobs:
1717
specification:
1818
runs-on: ubuntu-latest
19+
if: (github.event_name == 'pull_request' && !contains(github.event.pull_request.body, '[skip ci]')) ||
20+
(github.event_name == 'workflow_dispatch' && github.repository == 'scala/scala3') ||
21+
github.event_name == 'push' ||
22+
github.event_name == 'merge_group'
1923
defaults:
2024
run:
2125
working-directory: ./docs/_spec

0 commit comments

Comments
 (0)