Skip to content

Commit 54df87d

Browse files
Backport to branch(3.12) : Adjust precision of mapped datatype for ScalarDB BIGINT on Oracle (#2574)
Co-authored-by: Vincent Guilpain <[email protected]>
1 parent a36e580 commit 54df87d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineOracle.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ public boolean isConflict(SQLException e) {
180180
public String getDataTypeForEngine(DataType scalarDbDataType) {
181181
switch (scalarDbDataType) {
182182
case BIGINT:
183-
return "NUMBER(19)";
183+
return "NUMBER(16)";
184184
case BLOB:
185185
return "RAW(2000)";
186186
case BOOLEAN:

core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTestBase.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -480,7 +480,7 @@ public void createTable_forOracle_shouldExecuteCreateTableStatement()
480480
throws ExecutionException, SQLException {
481481
createTable_forX_shouldExecuteCreateTableStatement(
482482
RdbEngine.ORACLE,
483-
"CREATE TABLE \"my_ns\".\"foo_table\"(\"c3\" NUMBER(1),\"c1\" VARCHAR2(64),\"c4\" RAW(64),\"c2\" NUMBER(19),\"c5\" INT,\"c6\" BINARY_DOUBLE,\"c7\" BINARY_FLOAT, PRIMARY KEY (\"c3\",\"c1\",\"c4\")) ROWDEPENDENCIES",
483+
"CREATE TABLE \"my_ns\".\"foo_table\"(\"c3\" NUMBER(1),\"c1\" VARCHAR2(64),\"c4\" RAW(64),\"c2\" NUMBER(16),\"c5\" INT,\"c6\" BINARY_DOUBLE,\"c7\" BINARY_FLOAT, PRIMARY KEY (\"c3\",\"c1\",\"c4\")) ROWDEPENDENCIES",
484484
"ALTER TABLE \"my_ns\".\"foo_table\" INITRANS 3 MAXTRANS 255",
485485
"CREATE INDEX \"index_my_ns_foo_table_c4\" ON \"my_ns\".\"foo_table\" (\"c4\")",
486486
"CREATE INDEX \"index_my_ns_foo_table_c1\" ON \"my_ns\".\"foo_table\" (\"c1\")",
@@ -733,7 +733,7 @@ public void createTable_WithClusteringOrderForOracle_shouldExecuteCreateTableSta
733733
throws ExecutionException, SQLException {
734734
createTable_WithClusteringOrderForX_shouldExecuteCreateTableStatement(
735735
RdbEngine.ORACLE,
736-
"CREATE TABLE \"my_ns\".\"foo_table\"(\"c3\" NUMBER(1),\"c1\" VARCHAR2(64),\"c4\" RAW(64),\"c2\" NUMBER(19),\"c5\" INT,\"c6\" BINARY_DOUBLE,\"c7\" BINARY_FLOAT, PRIMARY KEY (\"c3\",\"c1\",\"c4\")) ROWDEPENDENCIES",
736+
"CREATE TABLE \"my_ns\".\"foo_table\"(\"c3\" NUMBER(1),\"c1\" VARCHAR2(64),\"c4\" RAW(64),\"c2\" NUMBER(16),\"c5\" INT,\"c6\" BINARY_DOUBLE,\"c7\" BINARY_FLOAT, PRIMARY KEY (\"c3\",\"c1\",\"c4\")) ROWDEPENDENCIES",
737737
"ALTER TABLE \"my_ns\".\"foo_table\" INITRANS 3 MAXTRANS 255",
738738
"CREATE UNIQUE INDEX \"my_ns.foo_table_clustering_order_idx\" ON \"my_ns\".\"foo_table\" (\"c3\" ASC,\"c1\" DESC,\"c4\" ASC)",
739739
"CREATE INDEX \"index_my_ns_foo_table_c4\" ON \"my_ns\".\"foo_table\" (\"c4\")",

0 commit comments

Comments
 (0)