Skip to content

Commit 82206d3

Browse files
committed
Drop two comments that restate or misdescribe the code
The javadoc on throwIfLikeConditionUnderIcuCollation repeated the rationale that CoreError.COLLATION_ICU_LIKE_CONDITION_NOT_SUPPORTED already states. The SnapshotKeyTest comment described a boundary sentinel that Snapshot.Key.buildIdentity does not have. The test name states the intent.
1 parent 7e2b587 commit 82206d3

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

core/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitOperationChecker.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@ public ConsensusCommitOperationChecker(
5353
this.collation = collation;
5454
}
5555

56-
/**
57-
* Rejects a LIKE or NOT_LIKE condition under the ICU collation. This layer re-evaluates a
58-
* selection's conditions itself and its pattern matching stays byte-exact at any collation, so on
59-
* a backend whose own collation governs LIKE the two would disagree.
60-
*/
6156
private void throwIfLikeConditionUnderIcuCollation(Selection selection) {
6257
if (collation != Collation.ICU) {
6358
return;

core/src/test/java/com/scalar/db/transaction/consensuscommit/SnapshotKeyTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -353,8 +353,7 @@ private Get prepareGetWithCompositePartitionKey(String value1, String value2) {
353353
@Test
354354
public void
355355
equals_CompositePartitionKeyVsSplitPartitionAndClusteringKeyUnderIcuPrimary_ShouldStayDistinct() {
356-
// Arrange: both shapes flatten to the TEXT components ['a', 'b'], so only the boundary
357-
// sentinel and the clustering-key presence marker keep their identities apart.
356+
// Arrange
358357
Snapshot.Key compositeKey =
359358
new Snapshot.Key(
360359
prepareGetWithCompositePartitionKey("a", "b"),

0 commit comments

Comments
 (0)