From 4baf2c29c0cc1cf0810a9cabf06bf6bbf33ae33c Mon Sep 17 00:00:00 2001 From: Vincent Guilpain Date: Fri, 21 Mar 2025 05:08:18 +0000 Subject: [PATCH 1/2] Empty commit [skip ci] From d336b9e170a25dadb91fe3ee3c85205bfc7d1715 Mon Sep 17 00:00:00 2001 From: Vincent Guilpain Date: Fri, 21 Mar 2025 14:51:41 +0900 Subject: [PATCH 2/2] Reduce precision of mapped ScalarDB BIGINT for Oracle from `NUMBER(19)` to `NUMBER(16)`` --- .../main/java/com/scalar/db/storage/jdbc/RdbEngineOracle.java | 2 +- .../java/com/scalar/db/storage/jdbc/JdbcAdminTestBase.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineOracle.java b/core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineOracle.java index 256d6eb13c..bdb90db1f9 100644 --- a/core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineOracle.java +++ b/core/src/main/java/com/scalar/db/storage/jdbc/RdbEngineOracle.java @@ -180,7 +180,7 @@ public boolean isConflict(SQLException e) { public String getDataTypeForEngine(DataType scalarDbDataType) { switch (scalarDbDataType) { case BIGINT: - return "NUMBER(19)"; + return "NUMBER(16)"; case BLOB: return "RAW(2000)"; case BOOLEAN: diff --git a/core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTestBase.java b/core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTestBase.java index 16f0781b4e..366ad1d3ef 100644 --- a/core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTestBase.java +++ b/core/src/test/java/com/scalar/db/storage/jdbc/JdbcAdminTestBase.java @@ -480,7 +480,7 @@ public void createTable_forOracle_shouldExecuteCreateTableStatement() throws ExecutionException, SQLException { createTable_forX_shouldExecuteCreateTableStatement( RdbEngine.ORACLE, - "CREATE TABLE \"my_ns\".\"foo_table\"(\"c3\" NUMBER(1),\"c1\" VARCHAR2(64),\"c4\" RAW(64),\"c2\" NUMBER(19),\"c5\" INT,\"c6\" BINARY_DOUBLE,\"c7\" BINARY_FLOAT, PRIMARY KEY (\"c3\",\"c1\",\"c4\")) ROWDEPENDENCIES", + "CREATE TABLE \"my_ns\".\"foo_table\"(\"c3\" NUMBER(1),\"c1\" VARCHAR2(64),\"c4\" RAW(64),\"c2\" NUMBER(16),\"c5\" INT,\"c6\" BINARY_DOUBLE,\"c7\" BINARY_FLOAT, PRIMARY KEY (\"c3\",\"c1\",\"c4\")) ROWDEPENDENCIES", "ALTER TABLE \"my_ns\".\"foo_table\" INITRANS 3 MAXTRANS 255", "CREATE INDEX \"index_my_ns_foo_table_c4\" ON \"my_ns\".\"foo_table\" (\"c4\")", "CREATE INDEX \"index_my_ns_foo_table_c1\" ON \"my_ns\".\"foo_table\" (\"c1\")", @@ -733,7 +733,7 @@ public void createTable_WithClusteringOrderForOracle_shouldExecuteCreateTableSta throws ExecutionException, SQLException { createTable_WithClusteringOrderForX_shouldExecuteCreateTableStatement( RdbEngine.ORACLE, - "CREATE TABLE \"my_ns\".\"foo_table\"(\"c3\" NUMBER(1),\"c1\" VARCHAR2(64),\"c4\" RAW(64),\"c2\" NUMBER(19),\"c5\" INT,\"c6\" BINARY_DOUBLE,\"c7\" BINARY_FLOAT, PRIMARY KEY (\"c3\",\"c1\",\"c4\")) ROWDEPENDENCIES", + "CREATE TABLE \"my_ns\".\"foo_table\"(\"c3\" NUMBER(1),\"c1\" VARCHAR2(64),\"c4\" RAW(64),\"c2\" NUMBER(16),\"c5\" INT,\"c6\" BINARY_DOUBLE,\"c7\" BINARY_FLOAT, PRIMARY KEY (\"c3\",\"c1\",\"c4\")) ROWDEPENDENCIES", "ALTER TABLE \"my_ns\".\"foo_table\" INITRANS 3 MAXTRANS 255", "CREATE UNIQUE INDEX \"my_ns.foo_table_clustering_order_idx\" ON \"my_ns\".\"foo_table\" (\"c3\" ASC,\"c1\" DESC,\"c4\" ASC)", "CREATE INDEX \"index_my_ns_foo_table_c4\" ON \"my_ns\".\"foo_table\" (\"c4\")",