Skip to content

Commit 57bc014

Browse files
authored
feat: prepare v1 release (#454)
1 parent f0d0e83 commit 57bc014

File tree

10 files changed

+19
-22
lines changed

10 files changed

+19
-22
lines changed

.github/workflows/deploy-package.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
- run: echo //registry.npmjs.org/:_authToken=${NPM_TOKEN} > .npmrc
3434
env:
3535
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
36-
- run: pnpm lerna publish -y --create-release github
36+
- run: pnpm lerna publish -y --bump major --create-release github
3737
env:
3838
HUSKY: 0
3939
GH_TOKEN: ${{ secrets.GH_TOKEN }}

CONTRIBUTING.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ If there is a match, thumbs up the issue with a 👍 and leave a comment if you
3131
When reporting an issue, include the following:
3232

3333
- The version of `scaleway-sdk-js` you are using (e.g. v1.0.0-beta1, v2.0.0, master, ...)
34-
- The environment and its version (e.g. NodeJS v16.10)
34+
- The environment and its version (e.g. NodeJS v18.10)
3535

3636
## Suggesting a feature
3737

README.md

+5-8
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,8 @@
22

33
This SDK enables you to interact with Scaleway APIs.
44

5-
**⚠️  Notes:**
6-
* The project is in beta, but should be fairly stable.
7-
* SDK only works from a node.js runtime, browser calls aren't supported yet.
5+
> **Warning**
6+
> SDK only works from a node.js runtime, browser calls aren't supported yet.
87
98
**🔗  Important links:**
109
* [Reference documentation](https://scaleway.github.io/scaleway-sdk-js)
@@ -13,7 +12,7 @@ This SDK enables you to interact with Scaleway APIs.
1312

1413
## Getting Started
1514

16-
You'll need a pair of access and secret keys to connect to Scaleway API. Please check the [documentation](https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key) on how to retrieve them.
15+
You'll need a pair of access and secret keys to connect to Scaleway API. Please check the [documentation](https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/) on how to retrieve them.
1716

1817
**A minimal setup** would look like this:
1918

@@ -75,13 +74,11 @@ The project is coded with Typescript, so don't hesitate to take advantage of it.
7574

7675
2. We export **errors** in the namespace `Errors`, allowing you to differentiate the cases (e.g. `Errors.PermissionsDeniedError`).
7776

78-
## Notes
79-
80-
### Contributing Guidelines
77+
## Contributing Guidelines
8178

8279
This repository is at its early stage and is still in active development.
8380
If you are looking for a way to contribute please read [CONTRIBUTING.md](./CONTRIBUTING.md).
8481

85-
### Reach us
82+
## Reach us
8683

8784
We love feedback. Feel free to reach us on [Scaleway Slack community](https://slack.scaleway.com/), we are waiting for you on [#opensource](https://scaleway-community.slack.com/app_redirect?channel=opensource).

examples/serverless-function-minimal/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
},
1313
"devDependencies": {
1414
"serverless-scaleway-functions": "^0.4.5",
15+
"@types/node": "^18.11.18",
1516
"typescript": "^4.9.5"
1617
},
1718
"description": "Minimal Typescript template to run Scaleway SDK-JS in a Function."

lerna.json

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"version": "independent",
66
"command": {
77
"publish": {
8-
"conventionalPrerelease": true,
98
"conventionalCommits": true,
109
"changelogPreset": "conventionalcommits"
1110
},

packages/clients/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ This SDK enables you to interact with Scaleway APIs.
99

1010
## Getting Started
1111

12-
You'll need a pair of access and secret keys to connect to Scaleway API. Please check the [documentation](https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key) on how to retrieve them.
12+
You'll need a pair of access and secret keys to connect to Scaleway API. Please check the [documentation](https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/) on how to retrieve them.
1313

1414
**A minimal setup** would look like this:
1515

packages/clients/src/scw/__tests__/client-ini-profile.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe('assertValidAuthenticationSecrets', () => {
4646
assertValidAuthenticationSecrets(value)
4747
}).toThrow(
4848
new Error(
49-
`Invalid secrets, accessKey & secretKey must be defined. See https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key`,
49+
`Invalid secrets, accessKey & secretKey must be defined. See https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/`,
5050
),
5151
)
5252
})
@@ -59,7 +59,7 @@ describe('assertValidAuthenticationSecrets', () => {
5959
})
6060
}).toThrow(
6161
new Error(
62-
`Invalid access key format 'SCW0123', expected SCWXXXXXXXXXXXXXXXXX format. See https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key`,
62+
`Invalid access key format 'SCW0123', expected SCWXXXXXXXXXXXXXXXXX format. See https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/`,
6363
),
6464
)
6565
})
@@ -72,7 +72,7 @@ describe('assertValidAuthenticationSecrets', () => {
7272
})
7373
}).toThrow(
7474
new Error(
75-
`Invalid secret key format 'e4b83996-4c60-449a-98d2', expected a UUID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. See https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key`,
75+
`Invalid secret key format 'e4b83996-4c60-449a-98d2', expected a UUID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. See https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/`,
7676
),
7777
)
7878
})

packages/clients/src/scw/client-ini-profile.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -99,17 +99,17 @@ export function assertValidAuthenticationSecrets(
9999
): asserts obj is AuthenticationSecrets {
100100
if (!(obj.accessKey && obj.secretKey)) {
101101
throw new Error(
102-
`Invalid secrets, accessKey & secretKey must be defined. See https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key`,
102+
`Invalid secrets, accessKey & secretKey must be defined. See https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/`,
103103
)
104104
}
105105
if (!isAccessKey(obj.accessKey)) {
106106
throw new Error(
107-
`Invalid access key format '${obj.accessKey}', expected SCWXXXXXXXXXXXXXXXXX format. See https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key`,
107+
`Invalid access key format '${obj.accessKey}', expected SCWXXXXXXXXXXXXXXXXX format. See https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/`,
108108
)
109109
}
110110
if (!isSecretKey(obj.secretKey)) {
111111
throw new Error(
112-
`Invalid secret key format '${obj.secretKey}', expected a UUID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. See https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key`,
112+
`Invalid secret key format '${obj.secretKey}', expected a UUID: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx. See https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/`,
113113
)
114114
}
115115
}

packages/clients/src/scw/client.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ export const createAdvancedClient = (...configs: ClientConfig[]): Client => {
6767
* Creates a Scaleway client with a profile.
6868
*
6969
* @example
70-
* Creates a client with credentials & default values (see https://www.scaleway.com/docs/console/my-project/how-to/generate-api-key):
70+
* Creates a client with credentials & default values (see https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/):
7171
* ```
7272
* import { createClient } from '@scaleway/sdk'
7373
*
@@ -82,7 +82,7 @@ export const createAdvancedClient = (...configs: ClientConfig[]): Client => {
8282
*
8383
* @example
8484
* Creates a client by loading values from the environment (see https://www.scaleway.com/en/docs/console/my-project/how-to/generate-api-key/#how-to-use-your-api-key)
85-
* or the config file created by CLI `scw init` (see https://www.scaleway.com/cli):
85+
* or the config file created by CLI `scw init` (see https://www.scaleway.com/en/cli/):
8686
* ```
8787
* import { loadProfileFromConfigurationFile } from '@scaleway/configuration-loader'
8888
* import { createClient } from '@scaleway/sdk'

packages/configuration-loader/src/yml-loader.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ const DETECT_SECTION_REGEX = /^\s*([^]+):\s*$/
66
const DETECT_ITEM_REGEX = /^\s*(.+?)\s*:\s*(.+?)\s*$/
77

88
/**
9-
* Converts Yaml to configuration map.
9+
* Converts YAML to configuration map.
1010
*
11-
* @param input - Yaml string
11+
* @param input - YAML string
1212
* @returns The configuration map
1313
*
1414
* @internal

0 commit comments

Comments
 (0)