feat(instance_server): deprecated placement_group_policy_respected (#2910)

* feat(instance_server): mark placement_group_policy_respected as deprecated

* update server names

Author: Codelax

docs/resources/instance_server.md

@@ -283,7 +283,7 @@ In addition to all arguments above, the following attributes are exported:
 
 ~> **Important:** Instance servers' IDs are [zoned](../guides/regions_and_zones.md#resource-ids), which means they are of the form `{zone}/{id}`, e.g. `fr-par-1/11111111-1111-1111-1111-111111111111`
 
-- `placement_group_policy_respected` - True when the placement group policy is respected.
+- `placement_group_policy_respected` - (Deprecated) Always false, use [instance_placement_group ressource](instance_placement_group.md) to known when the placement group policy is respected.
 - `root_volume`
     - `volume_id` - The volume ID of the root volume of the server.
 - `private_ip` - The Scaleway internal IP address of the server (Deprecated use [ipam_ip datasource](../data-sources/ipam_ip.md#instance-private-network-ip) instead).

internal/services/instance/server_test.go

@@ -702,8 +702,9 @@ func TestAccServer_WithPlacementGroup(t *testing.T) {
 					
 					resource "scaleway_instance_server" "base" {
 						count = 3
+						name = "tf-tests-server-${count.index}-with-placement-group"
 						image = "ubuntu_focal"
-						type  = "DEV1-S"
+						type  = "PLAY2-PICO"
 						placement_group_id = "${scaleway_instance_placement_group.ha.id}"
 						tags  = [ "terraform-test", "scaleway_instance_server", "placement_group" ]
 					}`,
@@ -712,9 +713,12 @@ func TestAccServer_WithPlacementGroup(t *testing.T) {
 					isServerPresent(tt, "scaleway_instance_server.base.1"),
 					isServerPresent(tt, "scaleway_instance_server.base.2"),
 					isPlacementGroupPresent(tt, "scaleway_instance_placement_group.ha"),
-					resource.TestCheckResourceAttr("scaleway_instance_server.base.0", "placement_group_policy_respected", "true"),
-					resource.TestCheckResourceAttr("scaleway_instance_server.base.1", "placement_group_policy_respected", "true"),
-					resource.TestCheckResourceAttr("scaleway_instance_server.base.2", "placement_group_policy_respected", "true"),
+					resource.TestCheckResourceAttr("scaleway_instance_placement_group.ha", "policy_respected", "true"),
+
+					// placement_group_policy_respected is deprecated and should always be false.
+					resource.TestCheckResourceAttr("scaleway_instance_server.base.0", "placement_group_policy_respected", "false"),
+					resource.TestCheckResourceAttr("scaleway_instance_server.base.1", "placement_group_policy_respected", "false"),
+					resource.TestCheckResourceAttr("scaleway_instance_server.base.2", "placement_group_policy_respected", "false"),
 				),
 			},
 		},