Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Schemathesis 4.0 #22

Open
edgarrmondragon opened this issue Jan 16, 2025 · 3 comments
Open

Compatibility with Schemathesis 4.0 #22

edgarrmondragon opened this issue Jan 16, 2025 · 3 comments

Comments

@edgarrmondragon
Copy link
Contributor

This action uses some deprecated options:

action/action.yml

Lines 62 to 69 in 8137aad

- run: |
source env/bin/activate
schemathesis run \
${{ inputs.schema }} \
--hypothesis-database=:memory: \
--hypothesis-max-examples=${{ inputs.max-examples }} \
--checks=${{ inputs.checks }} \
${{ inputs.args }} \

Namely

  • --hypothesis-database--generation-database
  • --hypothesis-max-examples--generation-max-examples

From https://github.com/schemathesis/schemathesis/releases/tag/v4.0.0a1.

@Stranger6667
Copy link
Member

Thanks!

I believe this could be fixed in a patch release by pinning the upper bound (i.e. validating version input), this way it will be backward-compatible. Then a major release may include all values renamed.

@edgarrmondragon
Copy link
Contributor Author

Thanks!

I believe this could be fixed in a patch release by pinning the upper bound (i.e. validating version input), this way it will be backward-compatible. Then a major release may include all values renamed.

Oh nothing to fix in reality at the moment i.m.o.! Just wanted to log it in case other impatient folks like myself run into errors with the 4.0 prereleases. FWIW I ran into this by requesting it like

    - uses: schemathesis/action@e8c36caf1285d9c955e282cf71793837f92308a4 # v1.0.4
      env:
        PIP_PRE: 1

so it's 100% my fault 😅

Thanks!

@Stranger6667
Copy link
Member

Aha, got it :) Anyway, updating this action should be done together with the Schemathesis v4 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants