Fix ReadBufferDataHandle.globalToLocalOffset()

tpietzsch · tpietzsch · commit 92339087fe88 · 2020-05-28T17:02:13.000+02:00
Missing parantheses broke it for off &gt; Integer.MAX_VALUE
diff --git a/src/main/java/org/scijava/io/handle/ReadBufferDataHandle.java b/src/main/java/org/scijava/io/handle/ReadBufferDataHandle.java
@@ -182,7 +182,7 @@ private byte[] readPage(final int pageID, final int slotID) throws IOException {
 	 * Calculates the offset in the current page for the given global offset
 	 */
 	private int globalToLocalOffset(final long off) {
-		return (int) off % pageSize;
+		return (int) (off % pageSize);
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ private byte[] readPage(final int pageID, final int slotID) throws IOException {`
`182`	`182`	`* Calculates the offset in the current page for the given global offset`
`183`	`183`	`*/`
`184`	`184`	`private int globalToLocalOffset(final long off) {`
`185`		`- return (int) off % pageSize;`
	`185`	`+ return (int) (off % pageSize);`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`@Override`