ReadBufferDataHandle: fixed calculating local offset

trnila · trnila · commit d3d14176cadb · 2020-01-06T12:29:06.000+01:00
offset should not be cast to int before modulo operation
diff --git a/src/main/java/org/scijava/io/handle/ReadBufferDataHandle.java b/src/main/java/org/scijava/io/handle/ReadBufferDataHandle.java
@@ -185,7 +185,7 @@ private byte[] readPage(final int pageID, final int slotID) throws IOException {
 	 * Calculates the offset in the current page for the given global offset
 	 */
 	private int globalToLocalOffset(final long off) {
-		return (int) off % pageSize;
+		return (int) (off % pageSize);
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ private byte[] readPage(final int pageID, final int slotID) throws IOException {`
`185`	`185`	`* Calculates the offset in the current page for the given global offset`
`186`	`186`	`*/`
`187`	`187`	`private int globalToLocalOffset(final long off) {`
`188`		`- return (int) off % pageSize;`
	`188`	`+ return (int) (off % pageSize);`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`@Override`