Skip to content

Commit 17578b2

Browse files
committed
Merge branch 'asset-upload-display-browser-download-url'
* asset-upload-display-browser-download-url: gh_asset_upload: Support verbose option gh_asset_upload: Display "browser_download_url" returned by GitHub API
2 parents 96042c2 + cc574a6 commit 17578b2

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

github_release.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ def print_asset_info(i, asset):
352352
print('')
353353

354354

355-
def gh_asset_upload(repo_name, tag_name, pattern, dry_run=False):
355+
def gh_asset_upload(repo_name, tag_name, pattern, dry_run=False, verbose=False):
356356
release = get_release_info(repo_name, tag_name)
357357
uploaded = False
358358
upload_url = release["upload_url"]
@@ -375,12 +375,15 @@ def gh_asset_upload(repo_name, tag_name, pattern, dry_run=False):
375375
with open(filename, 'rb') as f:
376376
basename = os.path.basename(filename)
377377
url = '{0}?name={1}'.format(upload_url, basename)
378-
print('url:', url)
378+
if verbose:
379+
print('url:', url)
379380
response = _request(
380381
'POST', url,
381382
headers={'Content-Type': 'application/octet-stream'},
382383
data=f.read())
383384
response.raise_for_status()
385+
asset = response.json()
386+
print('browser_download_url:', asset["browser_download_url"])
384387
uploaded = True
385388
if not uploaded:
386389
print("release {0}: skipping upload: "
@@ -389,8 +392,8 @@ def gh_asset_upload(repo_name, tag_name, pattern, dry_run=False):
389392

390393
gh_asset_upload.description = {
391394
"help": "Upload release assets",
392-
"params": ["repo_name", "tag_name", "pattern", "dry-run"],
393-
"optional_params": {"dry-run": bool}
395+
"params": ["repo_name", "tag_name", "pattern", "dry-run", "verbose"],
396+
"optional_params": {"dry-run": bool, "verbose": bool}
394397
}
395398

396399

0 commit comments

Comments
 (0)