feat: warn if cmake/ninja in build system requirements (#803)

Fix #780.

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

docs/configuration.md

@@ -343,6 +343,13 @@ historic compatibility if you'd like:
 wheel.expand-macos-universal-tags = true
 ```
 
+
+You can also specify a build tag:
+
+```{conftabs} wheel.build-tag 1
+
+```
+
 You can select only specific components to install:
 
 ```{conftabs} install.components ["python"]
@@ -355,6 +362,7 @@ And you can turn off binary stripping:
 
 ```
 
+
 ## Configuring CMake arguments and defines
 
 You can select a different build type, such as `Debug`:

src/scikit_build_core/build/wheel.py

@@ -9,6 +9,9 @@
 from pathlib import Path
 from typing import TYPE_CHECKING
 
+from packaging.requirements import Requirement
+from packaging.utils import canonicalize_name
+
 from .. import __version__
 from .._compat import tomllib
 from .._compat.typing import Literal, assert_never
@@ -139,12 +142,27 @@ def _build_wheel_impl(
 
     settings_reader.validate_may_exit()
 
+    # Warn if cmake or ninja is in build-system.requires
+    requirements = [
+        canonicalize_name(Requirement(p).name)
+        for p in pyproject.get("build-system", {}).get("requires", [])
+    ]
+    if "cmake" in requirements:
+        logger.warning(
+            "cmake should not be in build-system.requires - scikit-build-core will inject it as needed"
+        )
+    if "ninja" in requirements:
+        logger.warning(
+            "ninja should not be in build-system.requires - scikit-build-core will inject it as needed"
+        )
+
     metadata = get_standard_metadata(pyproject, settings)
 
     if metadata.version is None:
         msg = "project.version is not specified, must be statically present or tool.scikit-build metadata.version.provider configured when dynamic"
         raise AssertionError(msg)
 
+    # Get the closest (normally) importable name
     normalized_name = metadata.name.replace("-", "_").replace(".", "_")
 
     if settings.wheel.cmake: