fix: only strip Release and MinSizeRel builds by default (#898)

Fix #875.

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

README.md

@@ -282,7 +282,8 @@ build.verbose = false
 # The components to install. If empty, all default components are installed.
 install.components = []
 
-# Whether to strip the binaries. True for scikit-build-core 0.5+.
+# Whether to strip the binaries. True for release builds on scikit-build-core
+# 0.5+ (0.5-0.10.5 also incorrectly set this for debug builds).
 install.strip = true
 
 # The path (relative to platlib) for the file to generate.

src/scikit_build_core/resources/scikit-build.schema.json

@@ -303,7 +303,7 @@
         },
         "strip": {
           "type": "boolean",
-          "description": "Whether to strip the binaries. True for scikit-build-core 0.5+."
+          "description": "Whether to strip the binaries. True for release builds on scikit-build-core 0.5+ (0.5-0.10.5 also incorrectly set this for debug builds)."
         }
       }
     },

src/scikit_build_core/settings/skbuild_model.py

@@ -264,7 +264,8 @@ class InstallSettings:
 
     strip: Optional[bool] = None
     """
-    Whether to strip the binaries. True for scikit-build-core 0.5+.
+    Whether to strip the binaries. True for release builds on scikit-build-core
+    0.5+ (0.5-0.10.5 also incorrectly set this for debug builds).
     """
 
 

src/scikit_build_core/settings/skbuild_read_settings.py

@@ -228,7 +228,10 @@ def __init__(
             or self.settings.minimum_version >= Version("0.5")
         )
         if self.settings.install.strip is None:
-            self.settings.install.strip = install_policy
+            self.settings.install.strip = (
+                install_policy
+                and self.settings.cmake.build_type in {"Release", "MinSizeRel"}
+            )
 
         # If we noted earlier that auto-cmake was requested, handle it now
         if (