Skip to content

Commit 86d099e

Browse files
authored
MNT remove unused local var in sklearn.utils.estimator_checks.py (scikit-learn#31221)
1 parent ceac4a8 commit 86d099e

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

sklearn/utils/estimator_checks.py

-1
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,6 @@ def callback(
889889
# as xfail.
890890
check_result["status"] = "xfail"
891891
else:
892-
failed = True
893892
check_result["status"] = "failed"
894893

895894
if on_fail == "warn":

sklearn/utils/tests/test_estimator_checks.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1373,8 +1373,8 @@ def callback(
13731373
expected_failed_checks = _get_expected_failed_checks(est)
13741374
# This is to make sure we test a class that has some expected failures
13751375
assert len(expected_failed_checks) > 0
1376-
with warnings.catch_warnings(record=True) as records:
1377-
logs = check_estimator(
1376+
with warnings.catch_warnings(record=True):
1377+
check_estimator(
13781378
est,
13791379
expected_failed_checks=expected_failed_checks,
13801380
on_fail=None,

0 commit comments

Comments
 (0)