We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
sklearn.utils.estimator_checks.py
1 parent ceac4a8 commit 86d099eCopy full SHA for 86d099e
sklearn/utils/estimator_checks.py
@@ -889,7 +889,6 @@ def callback(
889
# as xfail.
890
check_result["status"] = "xfail"
891
else:
892
- failed = True
893
check_result["status"] = "failed"
894
895
if on_fail == "warn":
sklearn/utils/tests/test_estimator_checks.py
@@ -1373,8 +1373,8 @@ def callback(
1373
expected_failed_checks = _get_expected_failed_checks(est)
1374
# This is to make sure we test a class that has some expected failures
1375
assert len(expected_failed_checks) > 0
1376
- with warnings.catch_warnings(record=True) as records:
1377
- logs = check_estimator(
+ with warnings.catch_warnings(record=True):
+ check_estimator(
1378
est,
1379
expected_failed_checks=expected_failed_checks,
1380
on_fail=None,
0 commit comments