Skip to content

Commit 2296362

Browse files
FlorisHoogenboomragrawal
andauthoredDec 3, 2020
Make all operations on DataFrameMapper.transformed_names_ atomic. (#194)
Co-authored-by: Ritesh Agrawal <ragrawal@gmail.com>
1 parent ed82fb4 commit 2296362

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed
 

‎sklearn_pandas/dataframe_mapper.py

+7-4
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ def _transform(self, X, y=None, do_fit=False):
304304
self._build()
305305

306306
extracted = []
307-
self.transformed_names_ = []
307+
transformed_names_ = []
308308
for columns, transformers, options in self.built_features:
309309
input_df = options.get('input_df', self.input_df)
310310

@@ -333,10 +333,11 @@ def _transform(self, X, y=None, do_fit=False):
333333
extracted.append(_handle_feature(Xt))
334334

335335
alias = options.get('alias')
336+
336337
prefix = options.get('prefix', '')
337338
suffix = options.get('suffix', '')
338339

339-
self.transformed_names_ += self.get_names(
340+
transformed_names_ += self.get_names(
340341
columns, transformers, Xt, alias, prefix, suffix)
341342

342343
# handle features not explicitly selected
@@ -351,15 +352,17 @@ def _transform(self, X, y=None, do_fit=False):
351352
if do_fit:
352353
_call_fit(self.built_default.fit, Xt, y)
353354
Xt = self.built_default.transform(Xt)
354-
self.transformed_names_ += self.get_names(
355+
transformed_names_ += self.get_names(
355356
unsel_cols, self.built_default, Xt)
356357
else:
357358
# if not applying a default transformer,
358359
# keep column names unmodified
359-
self.transformed_names_ += unsel_cols
360+
transformed_names_ += unsel_cols
360361

361362
extracted.append(_handle_feature(Xt))
362363

364+
self.transformed_names_ = transformed_names_
365+
363366
# combine the feature outputs into one array.
364367
# at this point we lose track of which features
365368
# were created from which input columns, so it's

0 commit comments

Comments
 (0)