Skip to content

Commit 7785945

Browse files
committed
Merge pull request #18 from calpaterson/master
Remove workaround for sklearn bug #18
2 parents 0f14b29 + 1ae47ba commit 7785945

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

sklearn_pandas/__init__.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,6 @@ def _get_col_subset(self, X, cols):
9999
else:
100100
t = X.as_matrix(cols)
101101

102-
# there is an sklearn bug (#2374) which causes weird behavior
103-
# when 'object' type arrays are passed to labelling functions.
104-
# To get around this, in cases where all columns are strings
105-
# (represnted as object by Pandas), we convert the dtype to
106-
# numpy's string type
107-
if np.all(X.dtypes[cols] == 'object'):
108-
t = np.array(t, dtype='|S')
109-
110102
return t
111103

112104

0 commit comments

Comments
 (0)