Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the button to share to Twitter on each blog post #206

Closed
star1327p opened this issue Feb 3, 2025 · 4 comments
Closed

Remove the button to share to Twitter on each blog post #206

star1327p opened this issue Feb 3, 2025 · 4 comments

Comments

@star1327p
Copy link
Contributor

Each blog post still contains a button to share to Twitter, and we should remove the Twitter button as well.

https://blog.scikit-learn.org/updates/dev-api/

Related to Issue #199 and PR #200.

@lesteve
Copy link
Member

lesteve commented Feb 14, 2025

Indeed good point! Not super familiar with the blog setup, but do you want to have a closer look at how to remove it?

@star1327p
Copy link
Contributor Author

@lesteve I am not familiar with the blog setup, either. But I took a closer look and found the social-share module on the minimal-mistakes theme. The problem is that the scikit-learn blog just imports the module, so we have not been able to customize it.
https://github.com/mmistakes/minimal-mistakes/blob/master/_includes/social-share.html

@reshamas
Copy link
Member

Closed via #209 and #212

@lesteve
Copy link
Member

lesteve commented Feb 17, 2025

Nice, thanks a lot for this @reshamas 🙏!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants