Merge pull request #602 from scireum/feature/sbi/SequencedCollections

Simplifies code by utilizing sequenced collection helpers

Author: sabieber

src/main/java/sirius/db/es/ElasticQuery.java

@@ -410,7 +410,7 @@ private <X> List<X> autoinit(List<X> list) {
      * @return the query itself for fluent method calls
      */
     public ElasticQuery<E> withEffectiveIndices(List<Class<? extends E>> entitiesToQuery) {
-        this.descriptor = mixing.getDescriptor(entitiesToQuery.get(0));
+        this.descriptor = mixing.getDescriptor(entitiesToQuery.getFirst());
         this.additionalDescriptors = entitiesToQuery.stream().skip(1).map(type -> mixing.getDescriptor(type)).toList();
 
         return this;

src/main/java/sirius/db/es/LowLevelClient.java

@@ -365,7 +365,7 @@ public Optional<String> resolveIndexForAlias(String aliasName) {
                             .handle();
         }
 
-        return Optional.of(indexNames.get(0));
+        return Optional.of(indexNames.getFirst());
     }
 
     /**

src/main/java/sirius/db/es/constraints/BoolQueryBuilder.java

@@ -187,7 +187,7 @@ public ObjectNode build() {
         }
 
         if (musts == 1 && mustNots == 0 && filters == 0 && shoulds == 0 && Strings.isEmpty(name)) {
-            return must.get(0);
+            return must.getFirst();
         }
 
         ObjectNode query = Json.createObject();

src/main/java/sirius/db/es/constraints/ElasticFilterFactory.java

@@ -420,7 +420,7 @@ public ElasticConstraint maxScore(@Nonnull List<ElasticConstraint> constraints)
         }
 
         if (effectiveConstraints.size() == 1) {
-            return effectiveConstraints.get(0);
+            return effectiveConstraints.getFirst();
         }
 
         ArrayNode queries = Json.createArray();

src/main/java/sirius/db/es/suggest/SuggestionResult.java

@@ -77,7 +77,7 @@ public List<TermSuggestion> getSingleTermSuggestions(String suggester) {
             return Collections.emptyList();
         }
 
-        return textPartSuggestions.get(0).getTermSuggestions();
+        return textPartSuggestions.getFirst().getTermSuggestions();
     }
 
     /**

src/main/java/sirius/db/jdbc/SmartQuery.java

@@ -322,7 +322,7 @@ protected Iterator<E> pullNextBlock() {
 
             List<E> block = queryNextBlock();
             if (!block.isEmpty()) {
-                lastValue = block.get(block.size() - 1);
+                lastValue = block.getLast();
                 orderByValuesOfLastEntityDuringFetch = extractOrderByValues(lastValue);
             }
             return block.iterator();
@@ -760,7 +760,7 @@ private void createJoinFetch(Mapping field, List<Mapping> fields, List<Mapping>
             List<Mapping> fetchPath = new ArrayList<>();
             Mapping parent = field.getParent();
             while (parent != null) {
-                fetchPath.add(0, parent);
+                fetchPath.addFirst(parent);
                 parent = parent.getParent();
             }
             JoinFetch jf = rootFetch;

src/main/java/sirius/db/jdbc/constraints/CompoundValue.java

@@ -80,15 +80,15 @@ public Tuple<String, List<Object>> compileExpression(SmartQuery.Compiler compile
             }
         }
         if (components.size() == 1) {
-            return Tuple.create(sqlRepresentation.get(0), parameters);
+            return Tuple.create(sqlRepresentation.getFirst(), parameters);
         }
         return Tuple.create("(" + Strings.join(sqlRepresentation, ", ") + ")", parameters);
     }
 
     @Override
     public String toString() {
         if (components.size() == 1) {
-            return Objects.toString(components.get(0));
+            return Objects.toString(components.getFirst());
         }
         return "(" + components.stream().map(Objects::toString).collect(Collectors.joining(", ")) + ")";
     }

src/main/java/sirius/db/mixing/properties/MultiPointLocationProperty.java

@@ -104,7 +104,7 @@ public Object transformFromDatasource(Class<? extends BaseMapper<?, ?, ?>> mappe
             Object coordinates = ((Document) object.get()).get("coordinates");
             if (coordinates instanceof List<?>) {
                 return ((List<List<Double>>) coordinates).stream()
-                                                         .map(entry -> Tuple.create(entry.get(0), entry.get(1)))
+                                                         .map(entry -> Tuple.create(entry.getFirst(), entry.get(1)))
                                                          .collect(Collectors.toCollection(ArrayList::new));
             }
         }

src/main/java/sirius/db/mixing/query/BaseQuery.java

@@ -349,7 +349,7 @@ public E queryOne() {
         if (result.size() != 1) {
             return null;
         } else {
-            return result.get(0);
+            return result.getFirst();
         }
     }
 }

src/main/java/sirius/db/mixing/query/constraints/FilterFactory.java

@@ -392,7 +392,7 @@ public final C and(List<C> constraints) {
             return null;
         }
         if (effectiveConstraints.size() == 1) {
-            return effectiveConstraints.get(0);
+            return effectiveConstraints.getFirst();
         }
 
         return effectiveAnd(effectiveConstraints);
@@ -432,7 +432,7 @@ public final C or(List<C> constraints) {
             return null;
         }
         if (effectiveConstraints.size() == 1) {
-            return effectiveConstraints.get(0);
+            return effectiveConstraints.getFirst();
         }
 
         return effectiveOr(effectiveConstraints);