Add NPM_BUILD environment variable #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @phracek, I hope you don't mind me mentioning you like this, just making sure that someone notices this PR in here. |
|
Hi, thank you for the pull request and for the patience. I will try to run the tests at first: |
|
This pull request looks easy to review. What do you think @lholmquist @mhdawson? |
lholmquist
approved these changes
Apr 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to specify the npm script for the build step instead of
build, the same way you can useNPM_RUNto specify a different run script instead ofstart. My use case is that I want to build and deploy part of a monorepo. As it is, I have to copy the wholeassemblefile to my.s2idirectory and change it in there.I agree with the suggestion in issue #308 that the most appropriate name for this variable would be
NPM_BUILD. I have not found anything online that would indicate that it is already in use for something else.