Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Disable Github job status in PR when enable update_pull_request_status #129

Closed
henrywang opened this issue Mar 7, 2024 · 4 comments
Labels
type: feature New feature or request

Comments

@henrywang
Copy link

When enabled update_pull_request_status, there're will be two job status in PR for the same test. One is from github job status, the other is from testing farm status. It'll be better to add one option to disable github job status and only keep testing farm status?

The github job status doesn't have testing farm log/result URL (http://artifacts.osci.xxxx.xxx/testing-farm/uuid/) included. And keeping two job status for the same test does not make sense.

Thanks!

@zmiklank
Copy link
Collaborator

zmiklank commented Mar 7, 2024

Hi, what trigger do you use for testing-farm-as-github-action?

@henrywang
Copy link
Author

Hi, what trigger do you use for testing-farm-as-github-action?

I use pull_request_target event to trigger.

pull_request_target:
    types: [opened, synchronize, reopened]

@zmiklank
Copy link
Collaborator

I use pull_request_target event to trigger.

I think I understand what you mean now.
I do not like this current behavior either, we bumped into it about a year ago, when we wanted to do a migration from issue_coment to pull_request[_target] trigger in sclorg.

So I think we can start from adding a safe integration test, which would serve as very simple pull_request/pull_request_target trigger. Then we will have good reproducer.

@phracek phracek added the type: feature New feature or request label Apr 30, 2024
@zmiklank
Copy link
Collaborator

zmiklank commented May 3, 2024

And also I think this feature request is duplicate of #54.

@zmiklank zmiklank closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants