-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: access TF using Authorization header #232
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 93.36% 93.37% +0.01%
==========================================
Files 11 11
Lines 603 604 +1
Branches 114 114
==========================================
+ Hits 563 564 +1
Misses 40 40 ☔ View full report in Codecov by Sentry. |
Our tests are using the new Authorization header and passing, so I think it should be safe to merge this PR. |
@@ -34,7 +34,7 @@ | |||
"@octokit/plugin-throttling": "9.3.1", | |||
"@octokit/rest": "21.0.2", | |||
"@octokit/types": "13.5.0", | |||
"testing-farm": "^1.9.2", | |||
"testing-farm": "1.10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow this. Sometimes we have ^1.9.2
and sometimes 1.10.0
. I would prefer to keep format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my fault. I changed it in the last PR and didn't notice before merging. I prefer the format without ^
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this pull request. Some nit-picks. Only. Good work. I would prefer to update also README.md with reference to testing-farm repo in plumbers team, so user know where is API implementation.
Passing api_key in data object is now deprecated.
I have added a note about testing-farm lib to the README. @phracek PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this.
Passing api_key in data object is now deprecated.