Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: access TF using Authorization header #232

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Sep 13, 2024

Passing api_key in data object is now deprecated.

@jamacku jamacku added the type: feature New feature or request label Sep 13, 2024
@jamacku

This comment was marked as outdated.

@jamacku jamacku marked this pull request as ready for review September 13, 2024 14:01
@jamacku jamacku requested a review from phracek September 13, 2024 14:02
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.37%. Comparing base (270f0d1) to head (b8c0e65).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   93.36%   93.37%   +0.01%     
==========================================
  Files          11       11              
  Lines         603      604       +1     
  Branches      114      114              
==========================================
+ Hits          563      564       +1     
  Misses         40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamacku
Copy link
Member Author

jamacku commented Sep 13, 2024

Our tests are using the new Authorization header and passing, so I think it should be safe to merge this PR.

@@ -34,7 +34,7 @@
"@octokit/plugin-throttling": "9.3.1",
"@octokit/rest": "21.0.2",
"@octokit/types": "13.5.0",
"testing-farm": "^1.9.2",
"testing-farm": "1.10.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow this. Sometimes we have ^1.9.2 and sometimes 1.10.0. I would prefer to keep format.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault. I changed it in the last PR and didn't notice before merging. I prefer the format without ^.

Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull request. Some nit-picks. Only. Good work. I would prefer to update also README.md with reference to testing-farm repo in plumbers team, so user know where is API implementation.

Passing api_key in data object is now deprecated.
@jamacku
Copy link
Member Author

jamacku commented Sep 16, 2024

Thanks for this pull request. Some nit-picks. Only. Good work. I would prefer to update also README.md with reference to testing-farm repo in plumbers team, so user know where is API implementation.

I have added a note about testing-farm lib to the README. @phracek PTAL

@jamacku jamacku requested a review from phracek September 16, 2024 10:28
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this.

@jamacku jamacku merged commit 82b7c9f into sclorg:main Sep 16, 2024
7 checks passed
@jamacku jamacku deleted the auth branch September 16, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the newly supported authorization header when authenticating with Testing Farm
2 participants