Skip to content

Commit 9e6c5b3

Browse files
authored
Merge pull request #206 from scoverage/tidyup
Tidyup
2 parents 2364c64 + 46afb37 commit 9e6c5b3

File tree

3 files changed

+4
-21
lines changed

3 files changed

+4
-21
lines changed

build.gradle

+2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ gradlePlugin {
3030
id = 'org.scoverage'
3131
implementationClass = 'org.scoverage.ScoveragePlugin'
3232
displayName = 'Gradle Scoverage plugin'
33+
description = 'gradle-scoverage is a Gradle plugin for calculating code coverage using Scoverage'
3334
tags.set(['coverage', 'scala', 'scoverage'])
3435
}
3536
}
@@ -183,6 +184,7 @@ if (project.properties.containsKey('signing.keyId')) {
183184
signing {
184185
sign publishing.publications.mavenJava
185186
}
187+
project.tasks.publishMavenJavaPublicationToMavenRepository.inputs.files(project.tasks.signMavenJavaPublication)
186188
}
187189

188190
// see https://stackoverflow.com/questions/44679007

src/functionalTest/java/org/scoverage/CompositeBuildTest.java

-2
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,12 @@ public CompositeBuildTest() {
1818
super("composite-build");
1919
}
2020

21-
@Ignore
2221
@Test
2322
public void buildComposite() {
2423

2524
runComposite("clean", "build");
2625
}
2726

28-
@Ignore
2927
@Test
3028
public void reportComposite() {
3129

src/main/groovy/org/scoverage/ScoveragePlugin.groovy

+2-19
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import org.gradle.api.plugins.PluginAware
99
import org.gradle.api.plugins.scala.ScalaPlugin
1010
import org.gradle.api.tasks.SourceSet
1111
import org.gradle.api.tasks.TaskProvider
12-
import org.gradle.api.tasks.scala.ScalaCompile
1312
import org.gradle.api.tasks.testing.Test
1413

1514
import java.nio.file.Files
@@ -59,6 +58,8 @@ class ScoveragePlugin implements Plugin<PluginAware> {
5958
visible = false
6059
transitive = true
6160
description = 'Scoverage dependencies'
61+
canBeResolved = true
62+
canBeConsumed = false
6263
}
6364

6465
project.afterEvaluate {
@@ -399,22 +400,4 @@ class ScoveragePlugin implements Plugin<PluginAware> {
399400
}
400401
}
401402

402-
private Set<? extends Task> recursiveDependenciesOf(Task task, boolean sameProjectOnly) {
403-
def cache = sameProjectOnly ? sameProjectTaskDependencies : crossProjectTaskDependencies
404-
if (!cache.containsKey(task)) {
405-
def directDependencies = task.getTaskDependencies().getDependencies(task)
406-
if (sameProjectOnly) {
407-
directDependencies = directDependencies.findAll {
408-
it.project == task.project
409-
}
410-
}
411-
def nestedDependencies = directDependencies.collect { recursiveDependenciesOf(it, sameProjectOnly) }.flatten()
412-
def dependencies = directDependencies + nestedDependencies
413-
414-
cache.put(task, dependencies)
415-
return dependencies
416-
} else {
417-
return cache.get(task)
418-
}
419-
}
420403
}

0 commit comments

Comments
 (0)