Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning coverage on in the console can't be turned off #109

Closed
gregsymons opened this issue May 18, 2015 · 5 comments · Fixed by #113
Closed

Turning coverage on in the console can't be turned off #109

gregsymons opened this issue May 18, 2015 · 5 comments · Fixed by #113

Comments

@gregsymons
Copy link
Contributor

Once you turn on coverage in a given sbt session, it can't be turned off. I thought of adding a nocoverage task, but then I wondered if the truly correct solution would be to make enabled a Setting rather than the var it currently is. What do you think?

@sksamuel
Copy link
Member

sksamuel commented Jun 4, 2015

You mean once you've done sbt coverage, subsequent calls to sbt test produce output? If so, do a sbt clean compile and it should be gone.

@gregsymons
Copy link
Contributor Author

No, I mean if I'm running an sbt console (i.e. I run sbt with no task), if I execute the coverage task in that console session, then from that point on, compiling generates instrumented classes.

@sksamuel
Copy link
Member

sksamuel commented Jun 5, 2015

Ah right. That's because it sets a variable. I think we could add a
"coverageoff" one that does the opposite.

On 5 June 2015 at 23:13, Greg Symons [email protected] wrote:

No, I mean if I'm running an sbt console (i.e. I run sbt with no task),
if I execute the coverage task in that console session, then from that
point on, compiling generates instrumented classes.


Reply to this email directly or view it on GitHub
#109 (comment)
.

@gregsymons
Copy link
Contributor Author

Yep. I just wanted to see what your opinion on fixing it was before I dove in and did it. I'll go ahead and add coverageoff task and have a PR ready shortly.

@sksamuel
Copy link
Member

sksamuel commented Jun 7, 2015

1.2.0 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants