Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbt scoverage:test no longer runs the unit tests #30

Closed
RichardBradley opened this issue Jul 24, 2014 · 2 comments · Fixed by #35
Closed

sbt scoverage:test no longer runs the unit tests #30

RichardBradley opened this issue Jul 24, 2014 · 2 comments · Fixed by #35

Comments

@RichardBradley
Copy link
Contributor

These lines mean that the default action for sbt scoverage:test is now to run the integration tests, rather than the more conventional unit tests:

        // copy the test task into compile so we can do scoverage:test instead of scoverage-test:test etc
        test in ScoverageCompile <<= (test in ScoverageTest),
        test in ScoverageCompile <<= (test in ScoverageITest)

It should be more like:

        // copy the test task into compile so we can do scoverage:test instead of scoverage-test:test etc
        test in ScoverageCompile <<= (test in ScoverageTest)

(I can't seem to submit a PR -- github thinks my repos isn't a fork of this. Strange.)
@RichardBradley RichardBradley mentioned this issue Jul 24, 2014
Closed
@RichardBradley
Copy link
Contributor Author

I can't seem to submit a PR -- github thinks my repos isn't a fork of this. Strange.

Might be due to https://help.github.com/articles/what-happens-to-forks-when-a-repository-is-deleted-or-changes-visibility#deleting-a-public-repository
Maybe I made my fork before you renamed the repos to scoverage?
Never mind; I'll create a new fork

@sksamuel
Copy link
Member

You don't delete the repos when you move, you just assign it a new owner (in this case the scoverage user). Who knows what that does internally though.

RichardBradley added a commit to RichardBradley/sbt-scoverage-1 that referenced this issue Jul 25, 2014
@RichardBradley
scoverage#30 Default task for "scoverage:test" should be unit tests, …
6b7b4b1 
…not integration tests
@RichardBradley RichardBradley mentioned this issue Jul 25, 2014
Merged
sksamuel added a commit that referenced this issue Jul 25, 2014
@sksamuel
Merge pull request #35 from RichardBradley/master
537ea0d 
#30 Default task for "scoverage:test" should be unit tests, not integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sksamuel @RichardBradley