Skip to content

Coverage not excluding packages or files after upgrading to scala 3 and play 3 #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rohanr-kmon opened this issue Oct 18, 2024 · 3 comments

Comments

@rohanr-kmon
Copy link

Recently upgraded project to Scala 3.3.3 (was using scala 2 before), play 3.0.5 and sbt-scoverage 2.2.0. The below code to exclude route files was functional before but doesn't seem to be working anymore:

    coverageExcludedPackages := "<empty>;Reverse.*",
    coverageExcludedFiles := ".*Routes.*",

Coverage has dropped from 56% to 30% and i can't seem to exclude the router files with any regex combos. Are there any known bugs?

@ckipp01
Copy link
Member

ckipp01 commented Oct 18, 2024

Hey @rohanr-kmon this was merged in, but just not released yet. I just cut a new release, 2.2.2, which should fix this for you. Feel free to update (might take like 30 min to propagate), but then report back if it works for you or not.

@jozic
Copy link
Contributor

jozic commented Oct 18, 2024

Just a reminder, Scala 3.3.4+ or 3.4.2+ is required

#561

@rohanr-kmon
Copy link
Author

Thank you @ckipp01 and @jozic !

@ckipp01 ckipp01 closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants